Attention is currently required from: Maulik V Vaghela, Mario Scheithauer, Subrata Banik, Werner Zeh, Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55355 )
Change subject: soc/intel/elkhartlake: Enable PCH GBE
......................................................................
Patch Set 1:
(2 comments)
File src/soc/intel/elkhartlake/fsp_params.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121222):
https://review.coreboot.org/c/coreboot/+/55355/comment/f5976421_864563f8
PS1, Line 359: /*
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121222):
https://review.coreboot.org/c/coreboot/+/55355/comment/d8783cf4_c455d8ce
PS1, Line 366: params->PchLanEnable =0x0;
spaces required around that '=' (ctx:WxV)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55355
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6b0108e892064e804693a34e360034ae7dbee68f
Gerrit-Change-Number: 55355
Gerrit-PatchSet: 1
Gerrit-Owner: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 09 Jun 2021 14:28:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment