Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37426 )
Change subject: soc/intel/tigerlake: Fix build issues ......................................................................
Patch Set 4:
(13 comments)
https://review.coreboot.org/c/coreboot/+/37426/1/src/soc/intel/tigerlake/acp... File src/soc/intel/tigerlake/acpi/northbridge.asl:
https://review.coreboot.org/c/coreboot/+/37426/1/src/soc/intel/tigerlake/acp... PS1, Line 25: Name (_ADR, Zero) // _ADR: Address
I am not hitting any compile issue.
Below are compile error. we should sue only one method (_HID or _ADR).
coreboot toolchain v547de69de736 2019-10-18 Error 6154 - Warnings detected during compilation (reporting warnings as errors)
dsdt.asl 115: Device (PCI0) Warning 3073 - ^ Multiple types (Device object requires either a _HID or _ADR, but not both)
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... File src/soc/intel/tigerlake/chip.h:
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 210: ProbeTypeDciOob = 0x02,
please, no space before tabs
Ack
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 215: ProbeTypeManual = 0x07,
please, no space before tabs
Ack
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 217: } DebugConsent;
trailing whitespace
Ack
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/chi... PS3, Line 262:
trailing whitespace
Ack
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... File src/soc/intel/tigerlake/include/soc/romstage.h:
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 27: BOARD_TYPE_MOBILE = 0,
please, no spaces at the start of a line
Ack
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 27: BOARD_TYPE_MOBILE = 0,
code indent should use tabs where possible
Ack
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 28: BOARD_TYPE_DESKTOP = 1,
code indent should use tabs where possible
Ack
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 28: BOARD_TYPE_DESKTOP = 1,
please, no spaces at the start of a line
Ack
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 29: BOARD_TYPE_ULT_ULX = 5,
code indent should use tabs where possible
Ack
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 29: BOARD_TYPE_ULT_ULX = 5,
please, no spaces at the start of a line
Ack
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 30: BOARD_TYPE_SERVER = 7
code indent should use tabs where possible
Ack
https://review.coreboot.org/c/coreboot/+/37426/3/src/soc/intel/tigerlake/inc... PS3, Line 30: BOARD_TYPE_SERVER = 7
please, no spaces at the start of a line
Ack
-
Wonkyu Kim (Code Review)