Change in ...coreboot[master]: mb/google/sarien/variants/arcada: Adjust TP/TS/H1 I2C CLK to meet spec

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

Casper Chang (Code Review)

28 Jan 2019 28 Jan '19

1:35 p.m.

Casper Chang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31124

Change subject: mb/google/sarien/variants/arcada: Adjust TP/TS/H1 I2C CLK to meet spec ......................................................................

mb/google/sarien/variants/arcada: Adjust TP/TS/H1 I2C CLK to meet spec

After adjustment on Arcada EVT TouchScreen: 390 KHz TouchPad: 389 KHz H1: 389 KHz

BUG=b:120584026, b:120584561 BRANCH=master TEST=emerge-sarien coreboot chromeos-bootimage measure by scope

Change-Id: Ia6eb332e7a664b211a5025ad07e0d01bf7f8d5bb --- M src/mainboard/google/sarien/variants/arcada/devicetree.cb 1 file changed, 6 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/31124/1

diff --git a/src/mainboard/google/sarien/variants/arcada/devicetree.cb b/src/mainboard/google/sarien/variants/arcada/devicetree.cb index 2b0408e..f9d4582 100644 --- a/src/mainboard/google/sarien/variants/arcada/devicetree.cb +++ b/src/mainboard/google/sarien/variants/arcada/devicetree.cb @@ -77,17 +77,19 @@ .chipset_lockdown = CHIPSET_LOCKDOWN_COREBOOT, .i2c[0] = { .speed = I2C_SPEED_FAST, + .rise_time_ns = 52, + .fall_time_ns = 110, }, .i2c[1] = { .speed = I2C_SPEED_FAST, - .rise_time_ns = 176, - .fall_time_ns = 15, + .rise_time_ns = 52, + .fall_time_ns = 110, }, .i2c[4] = { .early_init = 1, .speed = I2C_SPEED_FAST, - .rise_time_ns = 452, - .fall_time_ns = 110, + .rise_time_ns = 36, + .fall_time_ns = 99, }, }"

Attachments:

attachment.htm (text/html — 3.4 KB)

Show replies by date

Casper Chang (Code Review)

28 Jan 28 Jan

1:36 p.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31124

to look at the new patch set (#2).

Change subject: mb/google/sarien/variants/arcada: Adjust TP/TS/H1 I2C CLK to meet spec ......................................................................

mb/google/sarien/variants/arcada: Adjust TP/TS/H1 I2C CLK to meet spec

After adjustment on Arcada EVT TouchScreen: 390 KHz TouchPad: 389 KHz H1: 389 KHz

BUG=b:120584026, b:120584561 BRANCH=master TEST=emerge-sarien coreboot chromeos-bootimage measure by scope Signed-off-by: Casper Chang casper_chang@wistron.corp-partner.google.com Change-Id: Ia6eb332e7a664b211a5025ad07e0d01bf7f8d5bb --- M src/mainboard/google/sarien/variants/arcada/devicetree.cb 1 file changed, 6 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/31124/2

Casper Chang (Code Review)

1:36 p.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31124

to look at the new patch set (#3).

Change subject: mb/google/sarien/variants/arcada: Adjust TP/TS/H1 I2C CLK to meet spec ......................................................................

mb/google/sarien/variants/arcada: Adjust TP/TS/H1 I2C CLK to meet spec

After adjustment on Arcada EVT TouchScreen: 390 KHz TouchPad: 389 KHz H1: 389 KHz

BUG=b:120584026, b:120584561 BRANCH=master TEST=emerge-sarien coreboot chromeos-bootimage measure by scope

Signed-off-by: Casper Chang casper_chang@wistron.corp-partner.google.com Change-Id: Ia6eb332e7a664b211a5025ad07e0d01bf7f8d5bb --- M src/mainboard/google/sarien/variants/arcada/devicetree.cb 1 file changed, 6 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/31124/3

Paul Menzel (Code Review)

4:22 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31124 )

Change subject: mb/google/sarien/variants/arcada: Adjust TP/TS/H1 I2C CLK to meet spec ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/31124/3//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/31124/3//COMMIT_MSG@9 PS3, Line 9: After adjustment on Arcada EVT : TouchScreen: 390 KHz : TouchPad: 389 KHz : H1: 389 KHz What was it before?

-- To view, visit https://review.coreboot.org/c/coreboot/+/31124 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia6eb332e7a664b211a5025ad07e0d01bf7f8d5bb Gerrit-Change-Number: 31124 Gerrit-PatchSet: 3 Gerrit-Owner: Casper Chang casper_chang@wistron.corp-partner.google.com Gerrit-Reviewer: Casper Chang casper_chang@wistron.corp-partner.google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 28 Jan 2019 16:22:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Casper Chang (Code Review)

29 Jan 29 Jan

3:28 a.m.

Casper Chang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31124 )

Change subject: mb/google/sarien/variants/arcada: Adjust TP/TS/H1 I2C CLK to meet spec ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/31124/3//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/31124/3//COMMIT_MSG@9 PS3, Line 9: After adjustment on Arcada EVT : TouchScreen: 390 KHz : TouchPad: 389 KHz : H1: 389 KHz

...

What was it before?

before modification TouchScreen: 470 kHz Touchpad: 440 kHz H1: 465 kHz

-- To view, visit https://review.coreboot.org/c/coreboot/+/31124 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia6eb332e7a664b211a5025ad07e0d01bf7f8d5bb Gerrit-Change-Number: 31124 Gerrit-PatchSet: 3 Gerrit-Owner: Casper Chang casper_chang@wistron.corp-partner.google.com Gerrit-Reviewer: Casper Chang casper_chang@wistron.corp-partner.google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 29 Jan 2019 03:28:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Casper Chang (Code Review)

3:10 p.m.

Casper Chang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31124 )

Change subject: mb/google/sarien/variants/arcada: Adjust TP/TS/H1 I2C CLK to meet spec ......................................................................

Patch Set 3: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/31124 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia6eb332e7a664b211a5025ad07e0d01bf7f8d5bb Gerrit-Change-Number: 31124 Gerrit-PatchSet: 3 Gerrit-Owner: Casper Chang casper_chang@wistron.corp-partner.google.com Gerrit-Reviewer: Casper Chang casper_chang@wistron.corp-partner.google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 29 Jan 2019 15:10:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Lijian Zhao (Code Review)

5:57 p.m.

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31124 )

Change subject: mb/google/sarien/variants/arcada: Adjust TP/TS/H1 I2C CLK to meet spec ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/31124 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia6eb332e7a664b211a5025ad07e0d01bf7f8d5bb Gerrit-Change-Number: 31124 Gerrit-PatchSet: 3 Gerrit-Owner: Casper Chang casper_chang@wistron.corp-partner.google.com Gerrit-Reviewer: Casper Chang casper_chang@wistron.corp-partner.google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 29 Jan 2019 17:57:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Lijian Zhao (Code Review)

5:57 p.m.

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31124 )

Change subject: mb/google/sarien/variants/arcada: Adjust TP/TS/H1 I2C CLK to meet spec ......................................................................

Patch Set 3:

...

Patch Set 3: Code-Review+1

Ideally people should not +1 themselves.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31124 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia6eb332e7a664b211a5025ad07e0d01bf7f8d5bb Gerrit-Change-Number: 31124 Gerrit-PatchSet: 3 Gerrit-Owner: Casper Chang casper_chang@wistron.corp-partner.google.com Gerrit-Reviewer: Casper Chang casper_chang@wistron.corp-partner.google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 29 Jan 2019 17:57:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Patrick Georgi (Code Review)

30 Jan 30 Jan

11:03 a.m.

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31124 )

Change subject: mb/google/sarien/variants/arcada: Adjust TP/TS/H1 I2C CLK to meet spec ......................................................................

mb/google/sarien/variants/arcada: Adjust TP/TS/H1 I2C CLK to meet spec

After adjustment on Arcada EVT TouchScreen: 390 KHz TouchPad: 389 KHz H1: 389 KHz

BUG=b:120584026, b:120584561 BRANCH=master TEST=emerge-sarien coreboot chromeos-bootimage measure by scope

Signed-off-by: Casper Chang casper_chang@wistron.corp-partner.google.com Change-Id: Ia6eb332e7a664b211a5025ad07e0d01bf7f8d5bb Reviewed-on: https://review.coreboot.org/c/31124 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Lijian Zhao lijian.zhao@intel.com --- M src/mainboard/google/sarien/variants/arcada/devicetree.cb 1 file changed, 6 insertions(+), 4 deletions(-)

Approvals: build bot (Jenkins): Verified Lijian Zhao: Looks good to me, approved Casper Chang: Looks good to me, but someone else must approve

-- To view, visit https://review.coreboot.org/c/coreboot/+/31124 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia6eb332e7a664b211a5025ad07e0d01bf7f8d5bb Gerrit-Change-Number: 31124 Gerrit-PatchSet: 4 Gerrit-Owner: Casper Chang casper_chang@wistron.corp-partner.google.com Gerrit-Reviewer: Casper Chang casper_chang@wistron.corp-partner.google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1979

days inactive

1981

days old

coreboot-gerrit@coreboot.org

8 comments

4 participants

tags (0)

participants (4)

Casper Chang (Code Review)
Lijian Zhao (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)