Attention is currently required from: Anil Kumar K, Jérémy Compostella, Krishna P Bhat D, Paul Menzel, Rizwan Qureshi, sridhar siricilla.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74577?usp=email )
Change subject: soc/intel/cse: Back up PSR data during CSE FW downgrade
......................................................................
Patch Set 54:
(4 comments)
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/74577/comment/5de765b4_e47e98d4 :
PS50, Line 1081: cse_boot_to_rw
While I understand you concern about losing the data and not being bothered, please have look at my […]
Acknowledged
https://review.coreboot.org/c/coreboot/+/74577/comment/eea303a7_f27bc6dd :
PS50, Line 1092: goto log_and_exit;
As Rizwan mentioned , we backup data whenever possible. […]
Acknowledged
https://review.coreboot.org/c/coreboot/+/74577/comment/e8cc7bea_7bd718d0 :
PS50, Line 1125: An attempt to send PSR back-up command has been made.
Subrata, Rizwan . based on this discussion are we good w.r. […]
Acknowledged
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/74577/comment/6c460b81_75cf20d2 :
PS52, Line 1115: if (backup_psr_resp.status != PSR_STATUS_SUCCESS)
will it make sense to just squash the elog patch (https://review.coreboot.org/c/coreboot/+/75760) into this one?
lets keep that as separate CL.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74577?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I135d197b5df0a20def823fe615860b5ead4391f8
Gerrit-Change-Number: 74577
Gerrit-PatchSet: 54
Gerrit-Owner: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anil Kumar K
anil.kumar.k@intel.corp-partner.google.com
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-CC: Himanshu Sahdev
himanshu.sahdev@intel.com
Gerrit-CC: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-CC: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-CC: sridhar siricilla
siricillasridhar@gmail.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: sridhar siricilla
siricillasridhar@gmail.com
Gerrit-Attention: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Comment-Date: Fri, 29 Sep 2023 08:05:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anil Kumar K
anil.kumar.k@intel.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Rizwan Qureshi
rizwan.qureshi@intel.com
Comment-In-Reply-To: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-MessageType: comment