[coreboot-gerrit] [M] Change in coreboot[main]: soc/intel/cse: Back up PSR data during CSE FW downgrade

[Subrata Banik (Code Review)]

Attention is currently required from: Anil Kumar K, Jérémy Compostella, Krishna P Bhat D, Paul Menzel, Rizwan Qureshi, sridhar siricilla.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74577?usp=email )

Change subject: soc/intel/cse: Back up PSR data during CSE FW downgrade
......................................................................

Patch Set 54:

(4 comments)

File src/soc/intel/common/block/cse/cse_lite.c:

https://review.coreboot.org/c/coreboot/+/74577/comment/5de765b4_e47e98d4 :
PS50, Line 1081: cse_boot_to_rw
> While I understand you concern about losing the data and not being bothered, please have look at my  […]

Acknowledged

https://review.coreboot.org/c/coreboot/+/74577/comment/eea303a7_f27bc6dd :
PS50, Line 1092: goto log_and_exit;
> > As Rizwan mentioned , we backup data whenever possible.  […]

Acknowledged

https://review.coreboot.org/c/coreboot/+/74577/comment/e8cc7bea_7bd718d0 :
PS50, Line 1125: An attempt to send PSR back-up command has been made.
> Subrata, Rizwan . based on this discussion are we good w.r. […]

Acknowledged

File src/soc/intel/common/block/cse/cse_lite.c:

https://review.coreboot.org/c/coreboot/+/74577/comment/6c460b81_75cf20d2 :
PS52, Line 1115: if (backup_psr_resp.status != PSR_STATUS_SUCCESS)
> will it make sense to just squash the elog patch (https://review.coreboot.org/c/coreboot/+/75760) into this one?

lets keep that as separate CL.