[S] Change in coreboot[master]: soc/amd/phoenix: Update phoenix2 VGA BIOS ID - coreboot-gerrit

3 Mar 2023


      Attention is currently required from: Jason Glenesk, Matt DeVillier, Fred Reitberger, Felix Held.
ritul guru has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73372 )
Change subject: soc/amd/phoenix: Update phoenix2 VGA BIOS ID
......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/phoenix/Kconfig:
https://review.coreboot.org/c/coreboot/+/73372/comment/10ff5212_db1c72d7 
PS1, Line 247: 1002,15c8
...
shouldn't this be 1002,1205 to match the pci id in the vbios so that both 1205 and 15c8 cases work a […]
phx2 has VBIOS DID as 15c8, so need to have VGA_BIOS_ID=1002,15c8 in but VBIOS rom has DID 0x1205 which is handled in map_oprom_vendev().
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/73372
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie035baf7a0908e1e6382c1810926647bf7182f6c
Gerrit-Change-Number: 73372
Gerrit-PatchSet: 1
Gerrit-Owner: ritul guru ritul.bits@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 03 Mar 2023 10:07:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment