Jamie Ryu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42070 )
Change subject: mb/google/volteer: Enable CSE Firmware Lite SKU ......................................................................
mb/google/volteer: Enable CSE Firmware Lite SKU
BUG=B:158140797 TEST=build and boot volteer with CSE Lite SKU
Change-Id: I4f939883617a1271b30c76d41e61113bbdd6ab5b Signed-off-by: Jamie Ryu jamie.m.ryu@intel.com --- M src/mainboard/google/volteer/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/42070/1
diff --git a/src/mainboard/google/volteer/Kconfig b/src/mainboard/google/volteer/Kconfig index 76acb9a..cc00b06 100644 --- a/src/mainboard/google/volteer/Kconfig +++ b/src/mainboard/google/volteer/Kconfig @@ -25,6 +25,7 @@ select MAINBOARD_HAS_TPM2 select PCIEXP_HOTPLUG select SOC_INTEL_TIGERLAKE + select SOC_INTEL_CSE_LITE_SKU
if BOARD_GOOGLE_BASEBOARD_VOLTEER
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42070 )
Change subject: mb/google/volteer: Enable CSE Firmware Lite SKU ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42070/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42070/1//COMMIT_MSG@11 PS1, Line 11: There need to be at least 2 changes going along with this: 1. Change for updating FMAP to accommodate Lite SKU 2. Change for adding the Lite SKU binaries and regenerating FIT
You will need Cq-Depend in your CLs to manage this correctly. Adding Sowmya who recently did this for Puff.
Hello build bot (Jenkins), Sowmya V,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42070
to look at the new patch set (#2).
Change subject: mb/google/volteer: Enable CSE Firmware Lite SKU ......................................................................
mb/google/volteer: Enable CSE Firmware Lite SKU
BUG=b:158140797 TEST=build and boot volteer with CSE Lite SKU Cq-Depend: chrome-internal:3100721
Change-Id: I4f939883617a1271b30c76d41e61113bbdd6ab5b Signed-off-by: Jamie Ryu jamie.m.ryu@intel.com --- M src/mainboard/google/volteer/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/42070/2
Jamie Ryu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42070 )
Change subject: mb/google/volteer: Enable CSE Firmware Lite SKU ......................................................................
Patch Set 3: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/42070/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42070/1//COMMIT_MSG@11 PS1, Line 11:
There need to be at least 2 changes going along with this: […]
1. FMAP change will be added on top of this change to add ME_FW blob 2. blob update is added by Cq-Depend: chrome-internal:3100721
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42070 )
Change subject: mb/google/volteer: Enable CSE Firmware Lite SKU ......................................................................
Patch Set 3: Code-Review+1
Change looks good, will give it a +2 once we're actually ready to enable CSME Lite on volteer. There are currently some open questions on the bug that will need to be resolved first.
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42070 )
Change subject: mb/google/volteer: Enable CSE Firmware Lite SKU ......................................................................
Patch Set 5: Code-Review+1
Hello build bot (Jenkins), Wonkyu Kim, Rizwan Qureshi, Sridhar Siricilla, Sowmya V, Nick Vaccaro, Raj Astekar,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42070
to look at the new patch set (#8).
Change subject: mb/google/volteer: Enable CSE Firmware Lite SKU ......................................................................
mb/google/volteer: Enable CSE Firmware Lite SKU
BUG=b:158140797 TEST=build and boot volteer with CSE Lite SKU Cq-Depend: chrome-internal:3100721
Change-Id: I4f939883617a1271b30c76d41e61113bbdd6ab5b Signed-off-by: Jamie Ryu jamie.m.ryu@intel.com --- M src/mainboard/google/volteer/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/42070/8
Hello build bot (Jenkins), Wonkyu Kim, Rizwan Qureshi, Sridhar Siricilla, Sowmya V, Nick Vaccaro, Raj Astekar,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42070
to look at the new patch set (#11).
Change subject: mb/google/volteer: Enable CSE Firmware Lite SKU ......................................................................
mb/google/volteer: Enable CSE Firmware Lite SKU
BUG=b:158140797 TEST=build and boot volteer with CSE Lite SKU Cq-Depend: chrome-internal:3100721
Change-Id: I4f939883617a1271b30c76d41e61113bbdd6ab5b Signed-off-by: Jamie Ryu jamie.m.ryu@intel.com --- M src/mainboard/google/volteer/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/42070/11
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42070 )
Change subject: mb/google/volteer: Enable CSE Firmware Lite SKU ......................................................................
Patch Set 12: -Code-Review
(1 comment)
https://review.coreboot.org/c/coreboot/+/42070/12/src/mainboard/google/volte... File src/mainboard/google/volteer/Kconfig:
https://review.coreboot.org/c/coreboot/+/42070/12/src/mainboard/google/volte... PS12, Line 28: SOC_INTEL_CSE_LITE_SKU Is there a CSME LITE that works for B-stepping?
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42070 )
Change subject: mb/google/volteer: Enable CSE Firmware Lite SKU ......................................................................
Patch Set 12:
Hi Jamie, Please rebase this patch so that it is on top of the relation chain instead of at the base. It should be merged last (i.e. make sure all fixes for CSME Lite mode are in place before enabling CSME Lite mode for any devices).
And by rebasing, it will allow us to get your other CLs that I've already +2'd merged while we wait for FAFT results to come in before approving and merging this particular change. Thanks.
Hello build bot (Jenkins), Wonkyu Kim, Rizwan Qureshi, Sridhar Siricilla, Sowmya V, Nick Vaccaro, Raj Astekar,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42070
to look at the new patch set (#14).
Change subject: mb/google/volteer: Enable CSE Firmware Lite SKU ......................................................................
mb/google/volteer: Enable CSE Firmware Lite SKU
BUG=b:158140797 TEST=build and boot volteer with CSE Lite SKU Cq-Depend: chrome-internal:3100721
Change-Id: I4f939883617a1271b30c76d41e61113bbdd6ab5b Signed-off-by: Jamie Ryu jamie.m.ryu@intel.com --- M src/mainboard/google/volteer/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/42070/14
Jamie Ryu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42070 )
Change subject: mb/google/volteer: Enable CSE Firmware Lite SKU ......................................................................
Patch Set 14:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42070/12/src/mainboard/google/volte... File src/mainboard/google/volteer/Kconfig:
https://review.coreboot.org/c/coreboot/+/42070/12/src/mainboard/google/volte... PS12, Line 28: SOC_INTEL_CSE_LITE_SKU
Is there a CSME LITE that works for B-stepping?
Nick, There will be a separate CSE Lite VIP kit release for B-stepping.
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42070 )
Change subject: mb/google/volteer: Enable CSE Firmware Lite SKU ......................................................................
Patch Set 15: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/42070/12/src/mainboard/google/volte... File src/mainboard/google/volteer/Kconfig:
https://review.coreboot.org/c/coreboot/+/42070/12/src/mainboard/google/volte... PS12, Line 28: SOC_INTEL_CSE_LITE_SKU
Nick, There will be a separate CSE Lite VIP kit release for B-stepping.
Done
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42070 )
Change subject: mb/google/volteer: Enable CSE Firmware Lite SKU ......................................................................
Patch Set 15: Code-Review-2
(1 comment)
https://review.coreboot.org/c/coreboot/+/42070/12/src/mainboard/google/volte... File src/mainboard/google/volteer/Kconfig:
https://review.coreboot.org/c/coreboot/+/42070/12/src/mainboard/google/volte... PS12, Line 28: SOC_INTEL_CSE_LITE_SKU
Done
@Jamie, that means that we can't set SOC_INTEL_CSE_LITE_SKU here as this setting applies to ALL variants. It must be set only for variants that are not preQS or QS (i.e. all variants should set SOC_INTEL_CSE_LITE_SKU EXCEPT for ripto, volteer2, and delbin).
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42070 )
Change subject: mb/google/volteer: Enable CSE Firmware Lite SKU ......................................................................
Patch Set 15:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42070/12/src/mainboard/google/volte... File src/mainboard/google/volteer/Kconfig:
https://review.coreboot.org/c/coreboot/+/42070/12/src/mainboard/google/volte... PS12, Line 28: SOC_INTEL_CSE_LITE_SKU
@Jamie, that means that we can't set SOC_INTEL_CSE_LITE_SKU here as this setting applies to ALL vari […]
To do this, please remove line 28 from this Kconfig file and add SOC_INTEL_CSE_LITE_SKU to each variant in the Kconfig.name file except for ripto, volteer2, and delbin.
Jamie Ryu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42070 )
Change subject: mb/google/volteer: Enable CSE Firmware Lite SKU ......................................................................
Patch Set 15:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42070/12/src/mainboard/google/volte... File src/mainboard/google/volteer/Kconfig:
https://review.coreboot.org/c/coreboot/+/42070/12/src/mainboard/google/volte... PS12, Line 28: SOC_INTEL_CSE_LITE_SKU
To do this, please remove line 28 from this Kconfig file and add SOC_INTEL_CSE_LITE_SKU to each vari […]
Nick, With current implementation, CSE SKU info is checked to execute CSE Lite specific code for CSE Lite SKU only, so platforms with Consumer SKU won't have an issue to boot and run with Consumer SKU. But I think you are right and it makes more sense to turn this only for the boards that use CSE Lite blob. Would you let me know the list of board name that uses es2 blob? I see halvor, malefor, terrador, trondo, volteer and voxel if I exclude ripto, volteer2 and delbin.
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42070 )
Change subject: mb/google/volteer: Enable CSE Firmware Lite SKU ......................................................................
Patch Set 15:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42070/12/src/mainboard/google/volte... File src/mainboard/google/volteer/Kconfig:
https://review.coreboot.org/c/coreboot/+/42070/12/src/mainboard/google/volte... PS12, Line 28: SOC_INTEL_CSE_LITE_SKU
Nick, With current implementation, CSE SKU info is checked to execute CSE Lite specific code for CSE […]
Yes, that is correct. Please add SOC_INTEL_CSE_LITE_SKU to the config in Kconfig.name for halvor, malefor, terrador, trondo, volteer, and voxel
Hello build bot (Jenkins), Wonkyu Kim, Jamie Ryu, Rizwan Qureshi, Sridhar Siricilla, Sowmya V, Nick Vaccaro, Raj Astekar,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42070
to look at the new patch set (#16).
Change subject: mb/google/volteer: Enable CSE Lite SKU for ES2 platforms ......................................................................
mb/google/volteer: Enable CSE Lite SKU for ES2 platforms
BUG=b:158140797 TEST=build and boot volteer with CSE Lite SKU Cq-Depend: chrome-internal:3100721
Change-Id: I4f939883617a1271b30c76d41e61113bbdd6ab5b Signed-off-by: Jamie Ryu jamie.m.ryu@intel.com --- M src/mainboard/google/volteer/Kconfig.name 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/42070/16
Jamie Ryu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42070 )
Change subject: mb/google/volteer: Enable CSE Lite SKU for ES2 platforms ......................................................................
Patch Set 16: Code-Review+1
Hello build bot (Jenkins), Wonkyu Kim, Jamie Ryu, Rizwan Qureshi, Sridhar Siricilla, Sowmya V, Nick Vaccaro, Raj Astekar,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42070
to look at the new patch set (#17).
Change subject: mb/google/volteer: Enable CSE Lite SKU for ES2 platforms ......................................................................
mb/google/volteer: Enable CSE Lite SKU for ES2 platforms
BUG=b:158140797 TEST=build and boot volteer with CSE Lite SKU Cq-Depend: chrome-internal:3100721
Change-Id: I4f939883617a1271b30c76d41e61113bbdd6ab5b Signed-off-by: Jamie Ryu jamie.m.ryu@intel.com --- M src/mainboard/google/volteer/Kconfig.name 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/42070/17
Jamie Ryu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42070 )
Change subject: mb/google/volteer: Enable CSE Lite SKU for ES2 platforms ......................................................................
Patch Set 17: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/42070/12/src/mainboard/google/volte... File src/mainboard/google/volteer/Kconfig:
https://review.coreboot.org/c/coreboot/+/42070/12/src/mainboard/google/volte... PS12, Line 28: SOC_INTEL_CSE_LITE_SKU
Yes, that is correct. Please add SOC_INTEL_CSE_LITE_SKU to the config in Kconfig. […]
Thanks! Patch#17 is updated for this change.
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42070 )
Change subject: mb/google/volteer: Enable CSE Lite SKU for ES2 platforms ......................................................................
Patch Set 17: Code-Review+1
Jamie Ryu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42070 )
Change subject: mb/google/volteer: Enable CSE Lite SKU for ES2 platforms ......................................................................
Patch Set 17:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42070/12/src/mainboard/google/volte... File src/mainboard/google/volteer/Kconfig:
https://review.coreboot.org/c/coreboot/+/42070/12/src/mainboard/google/volte... PS12, Line 28: SOC_INTEL_CSE_LITE_SKU
Thanks! Patch#17 is updated for this change.
Done
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42070 )
Change subject: mb/google/volteer: Enable CSE Lite SKU for ES2 platforms ......................................................................
Patch Set 18: Code-Review+2
Nick Vaccaro has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42070 )
Change subject: mb/google/volteer: Enable CSE Lite SKU for ES2 platforms ......................................................................
mb/google/volteer: Enable CSE Lite SKU for ES2 platforms
BUG=b:158140797 TEST=build and boot volteer with CSE Lite SKU Cq-Depend: chrome-internal:3100721
Change-Id: I4f939883617a1271b30c76d41e61113bbdd6ab5b Signed-off-by: Jamie Ryu jamie.m.ryu@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/42070 Reviewed-by: Nick Vaccaro nvaccaro@google.com Reviewed-by: Wonkyu Kim wonkyu.kim@intel.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/volteer/Kconfig.name 1 file changed, 6 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Nick Vaccaro: Looks good to me, approved Wonkyu Kim: Looks good to me, but someone else must approve Jamie Ryu: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/volteer/Kconfig.name b/src/mainboard/google/volteer/Kconfig.name index ccd104d..cfc4d34 100644 --- a/src/mainboard/google/volteer/Kconfig.name +++ b/src/mainboard/google/volteer/Kconfig.name @@ -3,10 +3,12 @@ config BOARD_GOOGLE_HALVOR bool "-> Halvor" select BOARD_GOOGLE_BASEBOARD_VOLTEER + select SOC_INTEL_CSE_LITE_SKU
config BOARD_GOOGLE_MALEFOR bool "-> Malefor" select BOARD_GOOGLE_BASEBOARD_VOLTEER + select SOC_INTEL_CSE_LITE_SKU
config BOARD_GOOGLE_RIPTO bool "-> Ripto" @@ -17,15 +19,18 @@ bool "-> Terrador" select BOARD_GOOGLE_BASEBOARD_VOLTEER select GBB_FLAG_DISABLE_EC_SOFTWARE_SYNC if CHROMEOS + select SOC_INTEL_CSE_LITE_SKU
config BOARD_GOOGLE_TRONDO bool "-> Trondo" select BOARD_GOOGLE_BASEBOARD_VOLTEER + select SOC_INTEL_CSE_LITE_SKU
config BOARD_GOOGLE_VOLTEER bool "-> Volteer" select BOARD_GOOGLE_BASEBOARD_VOLTEER select VARIANT_HAS_MIPI_CAMERA + select SOC_INTEL_CSE_LITE_SKU
config BOARD_GOOGLE_VOLTEER2 bool "-> Volteer2" @@ -35,6 +40,7 @@ config BOARD_GOOGLE_VOXEL bool "-> Voxel" select BOARD_GOOGLE_BASEBOARD_VOLTEER + select SOC_INTEL_CSE_LITE_SKU
config BOARD_GOOGLE_DELBIN bool "-> Delbin"
-
Furquan Shaikh (Code Review) -
Jamie Ryu (Code Review)
-
Nick Vaccaro (Code Review)
-
Sridhar Siricilla (Code Review)
-
Wonkyu Kim (Code Review)