Attention is currently required from: Jason Glenesk, Jakub Czapiga, Matt DeVillier, Grzegorz Bernacki, Tim Van Patten, Fred Reitberger, Felix Held.
Hello Konrad Adamczyk, build bot (Jenkins), Jason Glenesk, Raul Rangel, Jakub Czapiga, Matt DeVillier, Tim Van Patten, Fred Reitberger, Karthik Ramasubramanian, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/74716
to look at the new patch set (#2).
Change subject: soc/amd/common/block: Add missing cbfs_unmap()
......................................................................
soc/amd/common/block: Add missing cbfs_unmap()
cbfs_map() can allocate memory, so cbfs_unmap() should be
called before leaving the function.
BUG=278264488
TEST=Build and run with additional debug prints added
to confirm that data are correctly unmapped
Change-Id: Ibbebe7401e9f5a5312da1216408bf42fa2449db1
Signed-off-by: Grzegorz Bernacki bernacki@google.com
---
M src/device/pci_rom.c
M src/include/device/pci_rom.h
M src/soc/amd/common/block/cpu/update_microcode.c
M src/soc/amd/common/block/graphics/graphics.c
4 files changed, 51 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/74716/2
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74716
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibbebe7401e9f5a5312da1216408bf42fa2449db1
Gerrit-Change-Number: 74716
Gerrit-PatchSet: 2
Gerrit-Owner: Grzegorz Bernacki
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Konrad Adamczyk
konrada@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Grzegorz Bernacki
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: newpatchset