[M] Change in coreboot[master]: soc/intel/xeon_sp: Don't sort struct device cpus for numa

[Angel Pons (Code Review)]

Attention is currently required from: Arthur Heymans, Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin, Christian Walter, Shuming Chu (Shuming), TangYiwei.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68912 )

Change subject: soc/intel/xeon_sp: Don't sort struct device cpus for numa
......................................................................

Patch Set 3:

(1 comment)

File src/soc/intel/xeon_sp/nb_acpi.c:

https://review.coreboot.org/c/coreboot/+/68912/comment/a890a09d_f8ab8297 
PS3, Line 59: for (cpu = all_devices; cpu; cpu = cpu->next) {
            : 			if (!is_enabled_cpu(cpu))
            : 				continue;
            : 			if (cpu->path.apic.apic_id == apic_ids[i])
            : 				break;
            : 		}
> > Hmmm, having to re-do this search is a bit inefficient... […]

The idea would be to have a generic bubblesort function, so that it can be used for anything. Although it's not like we need to sort a lot of things in coreboot.

The thing is, it won't be type-safe because C doesn't have a type system, just numbers of varying sizes and purposes. In contrast, languages like Ada have an actual type system.

[please do not take the "type system" stuff *too* seriously]