Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35734 )
Change subject: intel/fsp_broadwell_de: Rename from xx_DEV_FUNC ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35734/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35734/1//COMMIT_MSG@7 PS1, Line 7: intel/fsp_broadwell_de: Rename from xx_DEV_FUNC What is the reason for renaming?
https://review.coreboot.org/c/coreboot/+/35734/1/src/soc/intel/fsp_broadwell... File src/soc/intel/fsp_broadwell_de/include/soc/pci_devs.h:
https://review.coreboot.org/c/coreboot/+/35734/1/src/soc/intel/fsp_broadwell... PS1, Line 118: #define PCIE_PORT1_DEV_FUNC PCI_DEVFN(PCIE_DEV, PCIE_PORT1_FUNC) Deleting of these lines is not mentioned in comment
-
Frans Hendriks (Code Review)