Attention is currently required from: Reka Norman, Tim Wawrzynczak, Rizwan Qureshi, Sridhar Siricilla, Angel Pons.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63365 )
Change subject: soc/intel/alderlake: Add support to update descriptor at runtime
......................................................................
Patch Set 7:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63365/comment/99ca72a0_c56d4d60
PS7, Line 10: following
follow-up
File src/soc/intel/alderlake/bootblock/update_descriptor.c:
https://review.coreboot.org/c/coreboot/+/63365/comment/cb50f55c_1a93a495
PS7, Line 22: host(Flash Master 1)
Please add a space before the (.
https://review.coreboot.org/c/coreboot/+/63365/comment/9c84f560_e44069fc
PS7, Line 23: int
Use bool?
https://review.coreboot.org/c/coreboot/+/63365/comment/6f572354_caed0168
PS7, Line 27: BIOS_DEBUG
Should be an error?
https://review.coreboot.org/c/coreboot/+/63365/comment/7facda35_64874735
PS7, Line 33: printk(BIOS_DEBUG, "Host doesn't have write access to Descriptor Region\n");
Ditto.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63365
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I43c4d2888706561e42ff6b8ce0377eedbc38dbfe
Gerrit-Change-Number: 63365
Gerrit-PatchSet: 7
Gerrit-Owner: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Reka Norman
rekanorman@google.com
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 06 Apr 2022 11:28:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment