Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46274 )
Change subject: {cpu,soc}/intel: deduplicate cpu code
......................................................................
Patch Set 18:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46274/18/src/cpu/intel/common/commo...
File src/cpu/intel/common/common.h:
https://review.coreboot.org/c/coreboot/+/46274/18/src/cpu/intel/common/commo...
PS18, Line 40: void set_energy_perf_bias(u8 policy);
Please write things out (or add comments). For instance, I can't say from the
top of my head what TPR or DCA are. The `policy` parameter could be an enum?
Or should also be commented.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46274
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib0cc834de8492d59c423317598e1c11847a0b1ab
Gerrit-Change-Number: 46274
Gerrit-PatchSet: 18
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 20 Oct 2020 10:44:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment