Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42690 )
Change subject: soc/amd/common: Drop ACPIMMIO GPIO bank separation
......................................................................
Patch Set 10:
Patch Set 10:
Patch Set 10:
Patch Set 10: Code-Review+2
this patch doesn't need the two patches before it in the same patch train to be merged before it lands, right? i don't think that this will cause issues, but I'll better verify before submitting patches out of the order in the patch train, so please confirm
apu2 needs to be adapted first, so don't merge this one yet (will break building)
if i've seen that correctly, currently it doesn't use this code; the first unmerged patch in this patch train adds that
CB:42521 apu2 needs to land first
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42690
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4c8c3f2028ca89dca5c7f0548fcd18e1045999d6
Gerrit-Change-Number: 42690
Gerrit-PatchSet: 10
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 16 Dec 2020 19:35:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment