Attention is currently required from: Martin L Roth, Matt DeVillier, Stefan Reinauer.
Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74926 )
Change subject: payloads/edk2: Hook up PCIe Resizable BARs flag
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
as long as it's in edk2-stable202302 I guess - or we need to make it conditional on using the upstre […]
The code is generic enough, i think it should work. We only found this issue because it hangs with one of our customers with resizable bar enabled and with a big graphic card, so I dont think I can reproduce it on our side as I dont have the hardware setup. This is actually found by Benjamin, that edk2payload should also have the resizable bar flag enabled or else there might be something wrong with the resources allocation.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74926
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5cc12d32c5e132b9f99ec650377d7683377c2a9c
Gerrit-Change-Number: 74926
Gerrit-PatchSet: 2
Gerrit-Owner: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Comment-Date: Wed, 03 May 2023 16:27:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-MessageType: comment