Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31736 )
Change subject: soc/amd/stoneyridge: Convert SMU fanless options
......................................................................
Patch Set 4:
I can't say I'm crazy about the way you're using the subprogram here, but i don't have a better idea.
I rassled with the concept for a while. Unfortunately, it's a little deeper than may be obvious. From what I can tell, different PSP implementations interpret the subprogram differently, depending on what family/model they are. As a result, I left the decision making with the soc/makefile instead of trying to put it inside the tool.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31736
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaae4094251974b8dad48b8d2c37bb2e43a412237
Gerrit-Change-Number: 31736
Gerrit-PatchSet: 4
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 07 Mar 2019 04:36:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment