[M] Change in coreboot[master]: mb/google/skyrim: Allow port descriptors to be overridden - coreboot-gerrit

1 Mar 2023


      Attention is currently required from: Martin L Roth, Jason Nien, Martin Roth.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73294 )
Change subject: mb/google/skyrim: Allow port descriptors to be overridden
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/skyrim/port_descriptors.c:
https://review.coreboot.org/c/coreboot/+/73294/comment/2be13262_756b90d0 
PS1, Line 99: 		*dxio_descs = skyrim_mdn_dxio_descriptors;
just curious, why don't we return skyrim_mdn_dxio_descriptors in weak function like gpio table do?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/73294
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8cff44f5b39d130a7191a69970cae8a88bb5d475
Gerrit-Change-Number: 73294
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth gaumless@gmail.com
Gerrit-Reviewer: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Jason Nien jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Martin L Roth gaumless@gmail.com
Gerrit-Attention: Jason Nien jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Wed, 01 Mar 2023 00:40:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment