Change in coreboot[master]: drivers/intel/fsp2_0: introduce possibility of using a full FD binary
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47993 )
Change subject: drivers/intel/fsp2_0: introduce possibility of using a full FD binary ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47993/4/src/drivers/intel/fsp2_0/Kc... File src/drivers/intel/fsp2_0/Kconfig:
https://review.coreboot.org/c/coreboot/+/47993/4/src/drivers/intel/fsp2_0/Kc... PS4, Line 60: !FSP_USE_REPO
Why did this change to !FSP_USE_REPO?
Only the string changed, that means, FSP_FD_PATH gets hidden in menuconfig, when FSP_USE_REPO is selected. Before it was not shown at all, so for !FSP_USE_REPO the behaviour does not change.
https://review.coreboot.org/c/coreboot/+/47993/4/src/drivers/intel/fsp2_0/Kc... PS4, Line 88: Use a combined FSP FD file instead of individual, split binaries.
Probably say that this takes as input a combined FSP FD file instead of individual, split binaries a […]
Not completely correct. FSP_FULL_FD is a boolean. The file then needs to be set in FSP_FD_PATH.
Since selecting FSP_FULL_FD then shows FSP_FD_PATH with its help text "Path to the FSP FD file that contains the individual FSP-T, FSP-M and FSP-S binaries.", I don't think we should add this redundant information here again.
I have added that part about splitting at runtime to both, though.
-
Michael Niewöhner (Code Review)