zanxi chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57642 )
Change subject: mb/google/trogdor: Add mipi panel for wormdingler ......................................................................
Patch Set 2:
(26 comments)
File src/drivers/mipi/panel-BOE_TV110C9M_LL0.c:
https://review.coreboot.org/c/coreboot/+/57642/comment/444984b0_071aa44a PS1, Line 36: PANEL_DCS(0xB0, 0x00, 0x08, 0x00, 0x23, 0x00, 0x4D, 0x00, \
Avoid unnecessary line continuations
Please fix.
File src/drivers/mipi/panel-BOE_TV110C9M_LL0.c:
https://review.coreboot.org/c/coreboot/+/57642/comment/e182c393_8d780f93 PS2, Line 36: PANEL_DCS(0xB0, 0x00, 0x08, 0x00, 0x23, 0x00, 0x4D, 0x00, 0x6D, \
Avoid unnecessary line continuations
Please fix.
https://review.coreboot.org/c/coreboot/+/57642/comment/94655eb7_24735fb7 PS2, Line 38: PANEL_DCS(0xB1, 0x00, 0xDA, 0x01, 0x13, 0x01, 0x3C, 0x01, 0x7E, \
Avoid unnecessary line continuations
Please fix.
https://review.coreboot.org/c/coreboot/+/57642/comment/6b7b9a12_51eba8f6 PS2, Line 40: PANEL_DCS(0xB2, 0x02, 0x67, 0x02, 0xA6, 0x02, 0xD1, 0x03, 0x08, \
Avoid unnecessary line continuations
Please fix.
https://review.coreboot.org/c/coreboot/+/57642/comment/2cf8d485_7ea652f2 PS2, Line 42: PANEL_DCS(0xB3, 0x03, 0x8E, 0x03, 0xA2, 0x03, 0xB7, 0x03, 0xE7, \
Avoid unnecessary line continuations
Please fix.
https://review.coreboot.org/c/coreboot/+/57642/comment/d08c846b_24fc4456 PS2, Line 44: PANEL_DCS(0xB4, 0x00, 0x08, 0x00, 0x23, 0x00, 0x4D, 0x00, 0x6D, \
Avoid unnecessary line continuations
Please fix.
https://review.coreboot.org/c/coreboot/+/57642/comment/e7dfbc77_4ca44914 PS2, Line 46: PANEL_DCS(0xB5, 0x00, 0xDA, 0x01, 0x13, 0x01, 0x3C, 0x01, 0x7E, \
Avoid unnecessary line continuations
Please fix.
https://review.coreboot.org/c/coreboot/+/57642/comment/ad4aad16_dc9cfcf6 PS2, Line 48: PANEL_DCS(0xB6, 0x02, 0x67, 0x02, 0xA6, 0x02, 0xD1, 0x03, 0x08, \
Avoid unnecessary line continuations
Please fix.
https://review.coreboot.org/c/coreboot/+/57642/comment/7c10399d_5f81b91a PS2, Line 50: PANEL_DCS(0xB7, 0x03, 0x8E, 0x03, 0xA2, 0x03, 0xB7, 0x03, 0xE7, \
Avoid unnecessary line continuations
Please fix.
https://review.coreboot.org/c/coreboot/+/57642/comment/ff8e2820_ad87d4a3 PS2, Line 52: PANEL_DCS(0xB8, 0x00, 0x08, 0x00, 0x23, 0x00, 0x4D, 0x00, 0x6D, \
Avoid unnecessary line continuations
Please fix.
https://review.coreboot.org/c/coreboot/+/57642/comment/c121aef7_2a60db55 PS2, Line 54: PANEL_DCS(0xB9, 0x00, 0xDA, 0x01, 0x13, 0x01, 0x3C, 0x01, 0x7E, \
Avoid unnecessary line continuations
Please fix.
https://review.coreboot.org/c/coreboot/+/57642/comment/d7e0ea22_e40d71ad PS2, Line 56: PANEL_DCS(0xBA, 0x02, 0x67, 0x02, 0xA6, 0x02, 0xD1, 0x03, 0x08, \
Avoid unnecessary line continuations
Please fix.
https://review.coreboot.org/c/coreboot/+/57642/comment/9a4a3d1f_ebfb042f PS2, Line 58: PANEL_DCS(0xBB, 0x03, 0x8E, 0x03, 0xA2, 0x03, 0xB7, 0x03, 0xE7, \
Avoid unnecessary line continuations
Please fix.
https://review.coreboot.org/c/coreboot/+/57642/comment/9d5c252e_ea5ccf3e PS2, Line 62: PANEL_DCS(0xB0, 0x00, 0x00, 0x00, 0x1B, 0x00, 0x45, 0x00, 0x65, \
Avoid unnecessary line continuations
Please fix.
https://review.coreboot.org/c/coreboot/+/57642/comment/d038a9e9_ed7b75d2 PS2, Line 64: PANEL_DCS(0xB1, 0x00, 0xD2, 0x01, 0x0B, 0x01, 0x34, 0x01, 0x76, \
Avoid unnecessary line continuations
Please fix.
https://review.coreboot.org/c/coreboot/+/57642/comment/8b67502d_8ec9fad5 PS2, Line 66: PANEL_DCS(0xB2, 0x02, 0x5F, 0x02, 0x9E, 0x02, 0xC9, 0x03, 0x00, \
Avoid unnecessary line continuations
Please fix.
https://review.coreboot.org/c/coreboot/+/57642/comment/a17636b2_d349754e PS2, Line 68: PANEL_DCS(0xB3, 0x03, 0x86, 0x03, 0x9A, 0x03, 0xAF, 0x03, 0xDF, \
Avoid unnecessary line continuations
Please fix.
https://review.coreboot.org/c/coreboot/+/57642/comment/f4b57494_b799e024 PS2, Line 70: PANEL_DCS(0xB4, 0x00, 0x00, 0x00, 0x1B, 0x00, 0x45, 0x00, 0x65, \
Avoid unnecessary line continuations
Please fix.
https://review.coreboot.org/c/coreboot/+/57642/comment/04cd6683_cdb6f01a PS2, Line 72: PANEL_DCS(0xB5, 0x00, 0xD2, 0x01, 0x0B, 0x01, 0x34, 0x01, 0x76, \
Avoid unnecessary line continuations
Please fix.
https://review.coreboot.org/c/coreboot/+/57642/comment/1679cc97_14cd2a8d PS2, Line 74: PANEL_DCS(0xB6, 0x02, 0x5F, 0x02, 0x9E, 0x02, 0xC9, 0x03, 0x00, \
Avoid unnecessary line continuations
Please fix.
https://review.coreboot.org/c/coreboot/+/57642/comment/30fb3a28_7c11d8cd PS2, Line 76: PANEL_DCS(0xB7, 0x03, 0x86, 0x03, 0x9A, 0x03, 0xAF, 0x03, 0xDF, \
Avoid unnecessary line continuations
Please fix.
https://review.coreboot.org/c/coreboot/+/57642/comment/4b6325b5_0c7367d6 PS2, Line 78: PANEL_DCS(0xB8, 0x00, 0x00, 0x00, 0x1B, 0x00, 0x45, 0x00, 0x65, \
Avoid unnecessary line continuations
Please fix.
https://review.coreboot.org/c/coreboot/+/57642/comment/85e0651a_773fee53 PS2, Line 80: PANEL_DCS(0xB9, 0x00, 0xD2, 0x01, 0x0B, 0x01, 0x34, 0x01, 0x76, \
Avoid unnecessary line continuations
Please fix.
https://review.coreboot.org/c/coreboot/+/57642/comment/48c70580_83b95bd9 PS2, Line 82: PANEL_DCS(0xBA, 0x02, 0x5F, 0x02, 0x9E, 0x02, 0xC9, 0x03, 0x00, \
Avoid unnecessary line continuations
Please fix.
https://review.coreboot.org/c/coreboot/+/57642/comment/eca632c8_5e0f984f PS2, Line 84: PANEL_DCS(0xBB, 0x03, 0x86, 0x03, 0x9A, 0x03, 0xAF, 0x03, 0xDF, \
Avoid unnecessary line continuations
Please fix.
https://review.coreboot.org/c/coreboot/+/57642/comment/89bd49f5_d3d0bf5d PS2, Line 166: PANEL_DCS(0xB6, 0x05, 0x00, 0x05, 0x00, 0x00, 0x00, 0x00, 0x00, \
Avoid unnecessary line continuations
Please fix.
-
zanxi chen (Code Review)