Attention is currently required from: Justin van Son, Patrick Rudolph, Christian Walter, David Milosevic.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67759 )
Change subject: mb/prodrive/hermes: Add part numbers to SMBIOS
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/prodrive/hermes/mainboard.c:
https://review.coreboot.org/c/coreboot/+/67759/comment/0e5f412a_efb4e6f6
PS2, Line 180: memset(buffer, 0, sizeof(buffer));
redundant call to memset. 'buffer' is already initialized to zero in line 176.
No, it's not redundant because the buffer is declared as `static`, so the initialization in line 176 only happens once.
Technically it shouldn't be needed because the way the strings are written to the buffer should guarantee that there's no leftover data, but it doesn't hurt to be careful.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67759
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I26c17ab37859c3306fe72c3f0cdc1d3787b48157
Gerrit-Change-Number: 67759
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: David Milosevic
David.Milosevic@9elements.com
Gerrit-CC: Justin van Son
justin.van.son@prodrive-technologies.com
Gerrit-CC: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Justin van Son
justin.van.son@prodrive-technologies.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: David Milosevic
David.Milosevic@9elements.com
Gerrit-Comment-Date: Fri, 07 Oct 2022 14:47:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: David Milosevic
David.Milosevic@9elements.com
Gerrit-MessageType: comment