Attention is currently required from: Jason Glenesk, Marshall Dawson, Matt DeVillier, Tim Wawrzynczak, Martin Roth, Tim Van Patten, Fred Reitberger, Karthik Ramasubramanian, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66804 )
Change subject: soc/amd: Add low/no battery mode to DPTC
......................................................................
Patch Set 16: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/66804/comment/1ff5f333_30331873
PS16, Line 7: soc/amd
soc/amd/common/acpi
https://review.coreboot.org/c/coreboot/+/66804/comment/071586ea_813d1ee8
PS16, Line 13: refactor CL
It's not really a refactor CL, it's adding new functionality.
File src/soc/amd/common/acpi/dptc.asl:
https://review.coreboot.org/c/coreboot/+/66804/comment/54f34c29_d30739f3
PS16, Line 20: (
Do we need to group these?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/66804
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icea10a3876a29744ad8485be1557e184bcbfa397
Gerrit-Change-Number: 66804
Gerrit-PatchSet: 16
Gerrit-Owner: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 02 Sep 2022 17:50:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment