Change in coreboot[master]: src/vendorcode/amd/fsp/picasso: Add HDMI 2.0 diable setting section o... - coreboot-gerrit

22 Apr 2021


      Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Marshall Dawson, Chris Wang, Felix Held.
Patrick Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52544 )
Change subject: src/vendorcode/amd/fsp/picasso: Add HDMI 2.0 diable setting section of FspmUpd.h
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS3:
...
Since these are bools on the FSP side, can we combine all 4 into a single 8-bit config item and spli […]
I'll try this with whole patch,
and is it great to define name as:
disable_hdmi2
also comment 
bit0: disable_hdmi2_ddi0
bit1: disbale_hdmi2_ddi1
bit2: disable_hdmi2_ddi2
bit3: disable_hdmi2_ddi3
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/52544
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie00389074f3718a23440c41ae0b116455aa8b603
Gerrit-Change-Number: 52544
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Huang patrick.huang@amd.corp-partner.google.com
Gerrit-Reviewer: Chris Wang chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Kangheui Won khwon@chromium.org
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: chris wang Chris.Wang@amd.com
Gerrit-CC: Martin Roth martinroth@google.com
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Attention: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Attention: Chris Wang chris.wang@amd.corp-partner.google.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 22 Apr 2021 05:25:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth martinroth@google.com
Gerrit-MessageType: comment