Attention is currently required from: Michael Niewöhner. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60372 )
Change subject: util/liveiso: Merge build scripts ......................................................................
Patch Set 2:
(2 comments)
File util/liveiso/build.sh:
https://review.coreboot.org/c/coreboot/+/60372/comment/6f5f5158_be45ba99 PS1, Line 6: echo "No config given. Exiting."
maybe also print usage like this? "Usage: build.sh <graphical.nix|console.nix|... […]
Done
https://review.coreboot.org/c/coreboot/+/60372/comment/268b6385_a11450f8 PS1, Line 12: nixos-config=$config
could be `nixos-config=${config}. […]
I also thought about that, but decided against it. It doesn't provide more advantages.
-
Felix Singer (Code Review)