Attention is currently required from: Eran Mitrani, Kapil Porwal, Subrata Banik.
Julius Werner has posted comments on this change by Kapil Porwal. ( https://review.coreboot.org/c/coreboot/+/82659?usp=email )
Change subject: libpayload/libc: Include region device APIs ......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
What's the overall plan on how we want to do this CSE sync from payload thing? It looks like CL:55 […]
Yes, we agree on the process. I was not talking about actually passing pointers to binaries loaded by coreboot into libpayload (we generally never do that). I was just talking about sharing code.
If code is to be shared between coreboot and depthcharge, that should be through commonlib (which is linked by default into libpayload nowadays). Like I said, I'm not sure if that's a good idea in practice for this or not so you may need to explore that. But either way, like I mentioned, whether we share code or make it a completely independent implementation, I don't think depthcharge should be using the region API (because it's existing interfaces don't).
-
Julius Werner (Code Review)