Attention is currently required from: Raul Rangel, Jon Murphy, Karthik Ramasubramanian, Mark Hasemeyer.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74101 )
Change subject: mb/google/myst: Enable eSPI SCI events
......................................................................
Patch Set 19: Code-Review+2
(1 comment)
File src/mainboard/google/myst/mainboard.c:
https://review.coreboot.org/c/coreboot/+/74101/comment/ab99cdd0_18eb80d2
PS19, Line 44: pm_write32(PM_ESPI_INTR_CTRL, PM_ESPI_DEV_INTR_MASK & ~(BIT(1)));
this is left over from guybrush LoL.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74101
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8fd858c484f6fcf952bcb4f756ba2e4728091d8b
Gerrit-Change-Number: 74101
Gerrit-PatchSet: 19
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Mark Hasemeyer
markhas@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Mark Hasemeyer
markhas@google.com
Gerrit-Comment-Date: Thu, 06 Apr 2023 01:44:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment