Attention is currently required from: Matt DeVillier.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61585 )
Change subject: mb/google/cyan: Fixup variant GPIOs
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
I found a few of the schematics, I couldn't find all.
e.g. Wizpig & Relm, I do see some of those you set to NC that are supposedly connected to the headphone jack detect signal on the schematic, but on the other hand there is also a note saying it was removed at one point for relm, but not wizpig.... /shrugs
If this works for you, it seems OK. I'll give +1 for now, and +2 later if no one else has any objections.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61585
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I50d4b3516eba8906042bb8dea768b229afcf11ea
Gerrit-Change-Number: 61585
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: CoolStar Organization
coolstarorganization@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Comment-Date: Thu, 03 Feb 2022 22:18:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment