Attention is currently required from: Eran Mitrani.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74885 )
Change subject: src/drivers/spi: add HID over SPI ACPI driver
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
we should move this code into mainboard until we make it generic
example:
1. GPIO reference \_SB.PCI0.GPIO seems very generic and won't work if GPIO controller are not sitting under PCI0
2. IRQ number should come from mainboard and can't be kept inside generic driver
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74885
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id51d385ce350cef23da4184b044c74569f4dd3f0
Gerrit-Change-Number: 74885
Gerrit-PatchSet: 2
Gerrit-Owner: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Comment-Date: Wed, 03 May 2023 09:52:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment