Attention is currently required from: Patrick Rudolph, Angel Pons, Arthur Heymans, Felix Held.
Michał Zieliński has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67666 )
Change subject: mb/hp: Add HP Compaq 8300 Elite SFF
......................................................................
Patch Set 4:
(2 comments)
File src/mainboard/hp/compaq_8300_elite_sff/cmos.layout:
https://review.coreboot.org/c/coreboot/+/67666/comment/875613fb_b710f608
PS3, Line 31: 960 16 r 0 mrc_scrambler_seed_chk
You don't need this if you don't use MRC. […]
Done
File src/mainboard/hp/compaq_8300_elite_sff/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/67666/comment/4f0d65dd_bd6a31f3
PS3, Line 4: register "gfx.use_spread_spectrum_clock" = "0"
: register "gpu_dp_b_hotplug" = "0"
: register "gpu_dp_c_hotplug" = "0"
: register "gpu_dp_d_hotplug" = "0"
You can remove 0 values from devicetree "registers", this gets turned into a struct initializer and […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67666
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib5322acc0210f000b53954e2925549358f86d5c8
Gerrit-Change-Number: 67666
Gerrit-PatchSet: 4
Gerrit-Owner: Michał Zieliński
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 20 Sep 2022 21:09:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment