Change in coreboot[master]: mb/google/zork: Fix Goodix touchscreen ACPI node

[Furquan Shaikh (Code Review)]

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43701 )

Change subject: mb/google/zork: Fix Goodix touchscreen ACPI node
......................................................................

mb/google/zork: Fix Goodix touchscreen ACPI node

This change does the following:
a. USI_REPORT_EN is no longer set to high in coreboot. Instead
GPIO_144 is exposed as stop_gpio in ACPI to allow OS to control this
pad as required.
b. Appropriate delays are added for power-down sequencing:
 - Delay after REPORT_EN is disabled - 1ms
 - Delay after RESET is asserted - 1ms

BUG=b:159501288

Signed-off-by: Furquan Shaikh 
Change-Id: If4d12fa0d4f4e5123d8fdccdabda996dcafa4523
---
M src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c
M src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c
M src/mainboard/google/zork/variants/dalboz/overridetree.cb
M src/mainboard/google/zork/variants/morphius/overridetree.cb
M src/mainboard/google/zork/variants/vilboz/overridetree.cb
5 files changed, 12 insertions(+), 7 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/43701/1

diff --git a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c
index f65a92e..5568194 100644
--- a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c
+++ b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c
@@ -158,11 +158,8 @@
    PAD_GPO(GPIO_142, HIGH),
    /* BT_DISABLE */
    PAD_GPO(GPIO_143, LOW),
-	/*
-	 * USI_REPORT_EN - TODO: Driver resets this later.
-	 * Do we want it high or low initially?
-	 */
-	PAD_GPO(GPIO_144, HIGH),
+	/*  USI_REPORT_EN */
+	PAD_GPO(GPIO_144, LOW),
 };

const __weak
diff --git a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c
index 55c66e6..c10c9f4 100644
--- a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c
+++ b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c
@@ -173,8 +173,7 @@
    /* UART1_TXD - FPMCU */
    PAD_NF(GPIO_143, UART1_TXD, PULL_NONE),
    /* USI_REPORT_EN */
-	/* TODO: Driver resets this later.  Do we want it high or low initially? */
-	PAD_GPO(GPIO_144, HIGH),
+	PAD_GPO(GPIO_144, LOW),
 };

const __weak
diff --git a/src/mainboard/google/zork/variants/dalboz/overridetree.cb b/src/mainboard/google/zork/variants/dalboz/overridetree.cb
index 98a93ed..bcfff1f 100644
--- a/src/mainboard/google/zork/variants/dalboz/overridetree.cb
+++ b/src/mainboard/google/zork/variants/dalboz/overridetree.cb
@@ -82,6 +82,9 @@
    		register "generic.probed" = "1"
    		register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_140)"
    		register "generic.reset_delay_ms" = "120"
+			register "generic.reset_off_delay_ms" = "1"
+			register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_144)"
+			register "generic.stop_off_delay_ms" = "1"
    		register "generic.has_power_resource" = "1"
    		register "hid_desc_reg_offset" = "0x01"
    		device i2c 5d on end
diff --git a/src/mainboard/google/zork/variants/morphius/overridetree.cb b/src/mainboard/google/zork/variants/morphius/overridetree.cb
index 1e9a2c8..bc98bee 100644
--- a/src/mainboard/google/zork/variants/morphius/overridetree.cb
+++ b/src/mainboard/google/zork/variants/morphius/overridetree.cb
@@ -67,6 +67,9 @@
    		register "generic.probed" = "1"
    		register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_140)"
    		register "generic.reset_delay_ms" = "120"
+			register "generic.reset_off_delay_ms" = "1"
+			register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_144)"
+			register "generic.stop_off_delay_ms" = "1"
    		register "generic.has_power_resource" = "1"
    		register "generic.disable_gpio_export_in_crs" = "1"
    		register "hid_desc_reg_offset" = "0x01"
diff --git a/src/mainboard/google/zork/variants/vilboz/overridetree.cb b/src/mainboard/google/zork/variants/vilboz/overridetree.cb
index 49d21d5..0f374cb 100644
--- a/src/mainboard/google/zork/variants/vilboz/overridetree.cb
+++ b/src/mainboard/google/zork/variants/vilboz/overridetree.cb
@@ -89,7 +89,10 @@
    		register "generic.irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GPIO_12)"
    		register "generic.probed" = "1"
    		register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_140)"
+			register "generic.reset_off_delay_ms" = "1"
    		register "generic.reset_delay_ms" = "120"
+			register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_144)"
+			register "generic.stop_off_delay_ms" = "1"
    		register "generic.has_power_resource" = "1"
    		register "hid_desc_reg_offset" = "0x01"
    		device i2c 5d on end

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43701 )

Change subject: mb/google/zork: Fix Goodix touchscreen ACPI node
......................................................................

Patch Set 1: Code-Review+2

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43701 )

Change subject: mb/google/zork: Fix Goodix touchscreen ACPI node
......................................................................

Patch Set 1: Code-Review+2

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43701 )

Change subject: mb/google/zork: Fix Goodix touchscreen ACPI node
......................................................................

mb/google/zork: Fix Goodix touchscreen ACPI node

This change does the following:
a. USI_REPORT_EN is no longer set to high in coreboot. Instead
GPIO_144 is exposed as stop_gpio in ACPI to allow OS to control this
pad as required.
b. Appropriate delays are added for power-down sequencing:
 - Delay after REPORT_EN is disabled - 1ms
 - Delay after RESET is asserted - 1ms

BUG=b:159501288

Signed-off-by: Furquan Shaikh 
Change-Id: If4d12fa0d4f4e5123d8fdccdabda996dcafa4523
Reviewed-on: https://review.coreboot.org/c/coreboot/+/43701
Tested-by: build bot (Jenkins) 
Reviewed-by: Felix Held 
Reviewed-by: Aaron Durbin 
---
M src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c
M src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c
M src/mainboard/google/zork/variants/dalboz/overridetree.cb
M src/mainboard/google/zork/variants/morphius/overridetree.cb
M src/mainboard/google/zork/variants/vilboz/overridetree.cb
5 files changed, 12 insertions(+), 7 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Aaron Durbin: Looks good to me, approved
  Felix Held: Looks good to me, approved

diff --git a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c
index f65a92e..5568194 100644
--- a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c
+++ b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c
@@ -158,11 +158,8 @@
    PAD_GPO(GPIO_142, HIGH),
    /* BT_DISABLE */
    PAD_GPO(GPIO_143, LOW),
-	/*
-	 * USI_REPORT_EN - TODO: Driver resets this later.
-	 * Do we want it high or low initially?
-	 */
-	PAD_GPO(GPIO_144, HIGH),
+	/*  USI_REPORT_EN */
+	PAD_GPO(GPIO_144, LOW),
 };

const __weak
diff --git a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c
index 55c66e6..c10c9f4 100644
--- a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c
+++ b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c
@@ -173,8 +173,7 @@
    /* UART1_TXD - FPMCU */
    PAD_NF(GPIO_143, UART1_TXD, PULL_NONE),
    /* USI_REPORT_EN */
-	/* TODO: Driver resets this later.  Do we want it high or low initially? */
-	PAD_GPO(GPIO_144, HIGH),
+	PAD_GPO(GPIO_144, LOW),
 };

const __weak
diff --git a/src/mainboard/google/zork/variants/dalboz/overridetree.cb b/src/mainboard/google/zork/variants/dalboz/overridetree.cb
index 98a93ed..bcfff1f 100644
--- a/src/mainboard/google/zork/variants/dalboz/overridetree.cb
+++ b/src/mainboard/google/zork/variants/dalboz/overridetree.cb
@@ -82,6 +82,9 @@
    		register "generic.probed" = "1"
    		register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_140)"
    		register "generic.reset_delay_ms" = "120"
+			register "generic.reset_off_delay_ms" = "1"
+			register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_144)"
+			register "generic.stop_off_delay_ms" = "1"
    		register "generic.has_power_resource" = "1"
    		register "hid_desc_reg_offset" = "0x01"
    		device i2c 5d on end
diff --git a/src/mainboard/google/zork/variants/morphius/overridetree.cb b/src/mainboard/google/zork/variants/morphius/overridetree.cb
index 1e9a2c8..bc98bee 100644
--- a/src/mainboard/google/zork/variants/morphius/overridetree.cb
+++ b/src/mainboard/google/zork/variants/morphius/overridetree.cb
@@ -67,6 +67,9 @@
    		register "generic.probed" = "1"
    		register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_140)"
    		register "generic.reset_delay_ms" = "120"
+			register "generic.reset_off_delay_ms" = "1"
+			register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_144)"
+			register "generic.stop_off_delay_ms" = "1"
    		register "generic.has_power_resource" = "1"
    		register "generic.disable_gpio_export_in_crs" = "1"
    		register "hid_desc_reg_offset" = "0x01"
diff --git a/src/mainboard/google/zork/variants/vilboz/overridetree.cb b/src/mainboard/google/zork/variants/vilboz/overridetree.cb
index 49d21d5..0f374cb 100644
--- a/src/mainboard/google/zork/variants/vilboz/overridetree.cb
+++ b/src/mainboard/google/zork/variants/vilboz/overridetree.cb
@@ -89,7 +89,10 @@
    		register "generic.irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GPIO_12)"
    		register "generic.probed" = "1"
    		register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_140)"
+			register "generic.reset_off_delay_ms" = "1"
    		register "generic.reset_delay_ms" = "120"
+			register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_144)"
+			register "generic.stop_off_delay_ms" = "1"
    		register "generic.has_power_resource" = "1"
    		register "hid_desc_reg_offset" = "0x01"
    		device i2c 5d on end