Change in coreboot[master]: lib/spd_bin: Use UNKNOWN for denoting missing part number

[Paul Menzel (Code Review)]

Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39527 )

Change subject: lib/spd_bin: Use UNKNOWN for denoting missing part number
......................................................................

lib/spd_bin: Use UNKNOWN for denoting missing part number

If no part number is found, currently the message below is logged.

SPD: module part number is

Change it to::

SPD: module part number is UNKNOWN

Change-Id: I281bc05b38a326f84255799eaf6f742381cffc12
Signed-off-by: Paul Menzel 
---
M src/lib/spd_bin.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/39527/1

diff --git a/src/lib/spd_bin.c b/src/lib/spd_bin.c
index 35bcb4c..54946dd 100644
--- a/src/lib/spd_bin.c
+++ b/src/lib/spd_bin.c
@@ -191,7 +191,7 @@
    /* Module Part Number */
    spd_get_name(spd, spd_name, type);

-	printk(BIOS_INFO, "SPD: module part number is %s\n", spd_name);
+	printk(BIOS_INFO, "SPD: module part number is %s\n", spd_name ? spd_name : "UNKNOWN");

printk(BIOS_INFO,
    	"SPD: banks %d, ranks %d, rows %d, columns %d, density %d Mb\n",

[Paul Menzel (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39527

to look at the new patch set (#2).

Change subject: lib/spd_bin: Use UNKNOWN for denoting missing part number
......................................................................

lib/spd_bin: Use UNKNOWN for denoting missing part number

If no part number is found, currently the message below is logged.

SPD: module part number is

Change it to::

SPD: module part number is UNKNOWN

Change-Id: I281bc05b38a326f84255799eaf6f742381cffc12
Signed-off-by: Paul Menzel 
---
M src/lib/spd_bin.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/39527/2

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39527 )

Change subject: lib/spd_bin: Use UNKNOWN for denoting missing part number
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39527/2/src/lib/spd_bin.c 
File src/lib/spd_bin.c:

https://review.coreboot.org/c/coreboot/+/39527/2/src/lib/spd_bin.c@192 
PS2, Line 192: spd_get_name
How about adding the "UNKNOWN" inside this function instead?

[XS] Change in coreboot[master]: lib/spd_bin: Use UNKNOWN for denoting missing part number

[Martin L Roth (Code Review)]

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/39527?usp=email )

Change subject: lib/spd_bin: Use UNKNOWN for denoting missing part number
......................................................................

Abandoned

This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.