Jeremy Soller has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43676 )
Change subject: mb/system76/lemp9: skip FSP init of UART2 ......................................................................
mb/system76/lemp9: skip FSP init of UART2
This UART is already initialized by coreboot for the console, it does not need to be initialized by the FSP.
Tested on lemp9.
Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: I7c299fd7cf6fe53d1f500a899a14e63e51ad6266 --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/43676/1
diff --git a/src/mainboard/system76/lemp9/devicetree.cb b/src/mainboard/system76/lemp9/devicetree.cb index 0bf24f3..f9dd104 100644 --- a/src/mainboard/system76/lemp9/devicetree.cb +++ b/src/mainboard/system76/lemp9/devicetree.cb @@ -43,6 +43,7 @@ # Serial I/O register "SerialIoDevMode" = "{ [PchSerialIoIndexI2C0] = PchSerialIoPci, // Touchpad + [PchSerialIoIndexUART2] = PchSerialIoSkipInit, // LPSS UART }"
# SATA
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43676 )
Change subject: mb/system76/lemp9: skip FSP init of UART2 ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43676/2/src/mainboard/system76/lemp... File src/mainboard/system76/lemp9/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43676/2/src/mainboard/system76/lemp... PS2, Line 45: = PchSerialIoPci, // Touchpad : [PchSerialIoIndexUART2] = P alignment/indentation
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43676 )
Change subject: mb/system76/lemp9: skip FSP init of UART2 ......................................................................
Patch Set 2: Code-Review+2
Hello build bot (Jenkins), Michael Niewöhner,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43676
to look at the new patch set (#3).
Change subject: mb/system76/lemp9: skip FSP init of UART2 ......................................................................
mb/system76/lemp9: skip FSP init of UART2
This UART is already initialized by coreboot for the console, it does not need to be initialized by the FSP.
Tested on lemp9.
Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: I7c299fd7cf6fe53d1f500a899a14e63e51ad6266 --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/43676/3
Hello build bot (Jenkins), Michael Niewöhner,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43676
to look at the new patch set (#5).
Change subject: mb/system76/lemp9: skip FSP init of UART2 ......................................................................
mb/system76/lemp9: skip FSP init of UART2
This UART is already initialized by coreboot for the console, it does not need to be initialized by the FSP.
Tested on lemp9.
Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: I7c299fd7cf6fe53d1f500a899a14e63e51ad6266 --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/43676/5
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43676 )
Change subject: mb/system76/lemp9: skip FSP init of UART2 ......................................................................
Patch Set 6:
tested; works fine for me, too
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43676 )
Change subject: mb/system76/lemp9: skip FSP init of UART2 ......................................................................
Patch Set 6: Code-Review+2
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43676 )
Change subject: mb/system76/lemp9: skip FSP init of UART2 ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43676/2/src/mainboard/system76/lemp... File src/mainboard/system76/lemp9/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43676/2/src/mainboard/system76/lemp... PS2, Line 45: = PchSerialIoPci, // Touchpad : [PchSerialIoIndexUART2] = P
alignment/indentation
I'll do a global reformat later anyways
Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43676 )
Change subject: mb/system76/lemp9: skip FSP init of UART2 ......................................................................
mb/system76/lemp9: skip FSP init of UART2
This UART is already initialized by coreboot for the console, it does not need to be initialized by the FSP.
Tested on lemp9.
Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: I7c299fd7cf6fe53d1f500a899a14e63e51ad6266 Reviewed-on: https://review.coreboot.org/c/coreboot/+/43676 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Singer felixsinger@posteo.net Reviewed-by: Michael Niewöhner foss@mniewoehner.de --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Michael Niewöhner: Looks good to me, approved
diff --git a/src/mainboard/system76/lemp9/devicetree.cb b/src/mainboard/system76/lemp9/devicetree.cb index 1579080..f8b3009 100644 --- a/src/mainboard/system76/lemp9/devicetree.cb +++ b/src/mainboard/system76/lemp9/devicetree.cb @@ -43,6 +43,7 @@ # Serial I/O register "SerialIoDevMode" = "{ [PchSerialIoIndexI2C0] = PchSerialIoPci, // Touchpad + [PchSerialIoIndexUART2] = PchSerialIoSkipInit, // LPSS UART }"
# Misc
-
Felix Singer (Code Review) -
Jeremy Soller (Code Review)
-
Michael Niewöhner (Code Review)