[M] Change in coreboot[master]: drivers/pc80/rtc/mc146818rtc.c: Add Kconfig for RTC CMOS base addresses
Attention is currently required from: Paul Menzel, Angel Pons, Kyösti Mälkki, Felix Held.
Jonathon Hall has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74903 )
Change subject: drivers/pc80/rtc/mc146818rtc.c: Add Kconfig for RTC CMOS base addresses ......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74903/comment/8c856dcd_b987fb01 PS2, Line 17: and the EC BRAM bank 1.
To me, this paragraph seems a bit unnecessary. […]
That's fine, I just felt like I usually get asked to add more explanation of why someone might want this feature :D
File src/drivers/pc80/rtc/Kconfig:
https://review.coreboot.org/c/coreboot/+/74903/comment/d51ed452_f13c7dca PS2, Line 9: depends on DRIVERS_MC146818
Should this be repeated or grouped under 'if' with added entries?
Some files (drivers/pc80/rtc/option.c,post.c) include mc146818.h but don't depend on DRIVERS_MC146818, so the new configs are still relevant.
-
Jonathon Hall (Code Review)