build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39895 )
Change subject: mb/ocp/tiogapass: Update UPD IIO bifurcation at run-time ......................................................................
Patch Set 5:
(20 comments)
https://review.coreboot.org/c/coreboot/+/39895/5/src/mainboard/ocp/tiogapass... File src/mainboard/ocp/tiogapass/skxsp_tp_iio.h:
https://review.coreboot.org/c/coreboot/+/39895/5/src/mainboard/ocp/tiogapass... PS5, Line 23: Socket0_Iou0 = 0, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39895/5/src/mainboard/ocp/tiogapass... PS5, Line 23: Socket0_Iou0 = 0, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39895/5/src/mainboard/ocp/tiogapass... PS5, Line 24: Socket0_Iou1, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39895/5/src/mainboard/ocp/tiogapass... PS5, Line 24: Socket0_Iou1, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39895/5/src/mainboard/ocp/tiogapass... PS5, Line 25: Socket0_Iou2, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39895/5/src/mainboard/ocp/tiogapass... PS5, Line 25: Socket0_Iou2, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39895/5/src/mainboard/ocp/tiogapass... PS5, Line 26: Socket0_Mcp0, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39895/5/src/mainboard/ocp/tiogapass... PS5, Line 26: Socket0_Mcp0, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39895/5/src/mainboard/ocp/tiogapass... PS5, Line 27: Socket0_Mcp1, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39895/5/src/mainboard/ocp/tiogapass... PS5, Line 27: Socket0_Mcp1, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39895/5/src/mainboard/ocp/tiogapass... PS5, Line 28: Socket1_Iou0, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39895/5/src/mainboard/ocp/tiogapass... PS5, Line 28: Socket1_Iou0, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39895/5/src/mainboard/ocp/tiogapass... PS5, Line 29: Socket1_Iou1, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39895/5/src/mainboard/ocp/tiogapass... PS5, Line 29: Socket1_Iou1, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39895/5/src/mainboard/ocp/tiogapass... PS5, Line 30: Socket1_Iou2, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39895/5/src/mainboard/ocp/tiogapass... PS5, Line 30: Socket1_Iou2, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39895/5/src/mainboard/ocp/tiogapass... PS5, Line 31: Socket1_Mcp0, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39895/5/src/mainboard/ocp/tiogapass... PS5, Line 31: Socket1_Mcp0, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39895/5/src/mainboard/ocp/tiogapass... PS5, Line 32: Socket1_Mcp1 code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39895/5/src/mainboard/ocp/tiogapass... PS5, Line 32: Socket1_Mcp1 please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)