build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28669 )
Change subject: mb/google/octopus: Close unused I2C bus 7 include SCL and SDA for Phaser
......................................................................
Patch Set 19:
(2 comments)
https://review.coreboot.org/#/c/28669/19/src/mainboard/google/octopus/varian...
File src/mainboard/google/octopus/variants/phaser/variant.c:
https://review.coreboot.org/#/c/28669/19/src/mainboard/google/octopus/varian...
PS19, Line 47: /* According to the sku id decide whether update touch
trailing whitespace
https://review.coreboot.org/#/c/28669/19/src/mainboard/google/octopus/varian...
PS19, Line 65: /* Find all children on bus to
trailing whitespace
--
To view, visit
https://review.coreboot.org/28669
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ad17761f2a053dc329bbec0a0a3284d47289666
Gerrit-Change-Number: 28669
Gerrit-PatchSet: 19
Gerrit-Owner: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jett Rink
jettrink@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 25 Sep 2018 01:23:52 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No