Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Mohan Viswanathan, Name of user not set #1004133, Al Hirani, Avinash Alevoor, Rob Barnes, Fred Reitberger, Felix Held.
Jason Glenesk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61462 )
Change subject: soc/amd/common/block/psp: add PSP command
......................................................................
Patch Set 6:
(3 comments)
File src/soc/amd/common/block/psp/Kconfig:
https://review.coreboot.org/c/coreboot/+/61462/comment/faa68add_65470337
PS5, Line 34: select SOC_AMD_COMMON_BLOCK_PSP
this shouldn't be selected here. […]
Done
File src/soc/amd/common/block/psp/psp.c:
https://review.coreboot.org/c/coreboot/+/61462/comment/faada60c_9a92d2e4
PS5, Line 80: BOOT_STATE_INIT_ENTRY(BS_PAYLOAD_BOOT, BS_ON_ENTRY,
: psp_set_spl_fuse, NULL);
this should be moved to the psp_gen2 file which also avoids having to make this function visible out […]
Done
File src/soc/amd/common/block/psp/psp_def.h:
https://review.coreboot.org/c/coreboot/+/61462/comment/c00b23a1_4795fc5c
PS5, Line 30: #define CORE_2_PSP_MSG_38_FUSE_SPL 0x00001000
at least for me this would be easier to read if it was in the BIT(x) or (1 << x) form
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61462
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If0575356a7c6172e2e0f2eaf9d1a6706468fe92d
Gerrit-Change-Number: 61462
Gerrit-PatchSet: 6
Gerrit-Owner: Jason Glenesk
jason.glenesk@amd.corp-partner.google.com
Gerrit-Reviewer: Al Hirani
al.hirani13@gmail.com
Gerrit-Reviewer: Avinash Alevoor
Gerrit-Reviewer: Fred Reitberger
fred.reitberger@amd.corp-partner.google.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Mohan Viswanathan
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Name of user not set #1004133
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Mohan Viswanathan
Gerrit-Attention: Name of user not set #1004133
Gerrit-Attention: Al Hirani
al.hirani13@gmail.com
Gerrit-Attention: Avinash Alevoor
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Attention: Fred Reitberger
fred.reitberger@amd.corp-partner.google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 03 Feb 2022 15:43:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment