Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Paul Menzel, Angel Pons, Sridhar Siricilla, Patrick Rudolph.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61304 )
Change subject: soc/intel/common/block/cse: Add check before heci_reset() in heci_init()
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/61304/comment/80ed45c0_fde7b029
PS3, Line 92: {
Are you suggesting something like EARLY_HECI_INIT config to restrict the heci_init() call for older platform. If I'm not wrong, it's on SKL when heci_init() is getting called from bootblock which can be moved to romstage.
actually you're right, if SKL/KBL don't need to call heci_init() in bootblock, it should be moved to romstage to be consistent with the rest of the platforms.
that, along with the checks you proposed above, should mitigate the long timeout when heci_reset() is called on devices which do not have an active/enabled ME
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61304
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idf1735926cb3233a92bf6635e616a58c6448f542
Gerrit-Change-Number: 61304
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sun, 23 Jan 2022 19:42:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Gerrit-MessageType: comment