[S] Change in coreboot[main]: drivers/vpd: Add vpd_get_feature_level() API - coreboot-gerrit

5 Mar 2024


      Attention is currently required from: Eric Lai, Gwendal Grignou, Nick Vaccaro, Shelley Chen.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80805?usp=email )
Change subject: drivers/vpd: Add vpd_get_feature_level() API
......................................................................
Patch Set 2:
(1 comment)
File src/drivers/vpd/vpd_device_feature.c:
https://review.coreboot.org/c/coreboot/+/80805/comment/f15e5024_9bac19c6 :
PS2, Line 21: VPD_RW
...
interesting, shouldn't this be in the RO?
we have kept CBX feature as part of the RW VPD so, it can be field updatable (if required)
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/80805?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I76fc220ed792abdfefb0b1a37873b5b828bfdda8
Gerrit-Change-Number: 80805
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Eric Lai ericllai@google.com
Gerrit-Reviewer: Gwendal Grignou gwendal@chromium.org
Gerrit-Reviewer: Kapil Porwal kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Shelley Chen shchen@google.com
Gerrit-Attention: Eric Lai ericllai@google.com
Gerrit-Attention: Nick Vaccaro nvaccaro@google.com
Gerrit-Attention: Gwendal Grignou gwendal@chromium.org
Gerrit-Comment-Date: Tue, 05 Mar 2024 03:26:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai ericllai@google.com
Gerrit-MessageType: comment