Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29547 )
Change subject: security/vboot: Add measured boot mode
......................................................................
Patch Set 43:
(4 comments)
https://review.coreboot.org/#/c/29547/43/src/security/tpm/tspi/tspi.c
File src/security/tpm/tspi/tspi.c:
https://review.coreboot.org/#/c/29547/43/src/security/tpm/tspi/tspi.c@219
PS43, Line 219: //tcpa_log_add_table_entry(name, pcr, digest, digest_len);
please don't include dead code
https://review.coreboot.org/#/c/29547/43/src/security/vboot/vboot_crtm.c
File src/security/vboot/vboot_crtm.c:
https://review.coreboot.org/#/c/29547/43/src/security/vboot/vboot_crtm.c@35
PS43, Line 35: prog_name(&bootblock),
coding style is non uniform in this function
https://review.coreboot.org/#/c/29547/43/src/security/vboot/vboot_crtm.c@56
PS43, Line 56:
move tpm_measure_region() here to increase readability
https://review.coreboot.org/#/c/29547/43/src/security/vboot/vboot_crtm.c@80
PS43, Line 80: if (IS_ENABLED(CONFIG_VBOOT_SEPARATE_VERSTAGE)) {
else if ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29547
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I339a2f1051e44f36aba9f99828f130592a09355e
Gerrit-Change-Number: 29547
Gerrit-PatchSet: 43
Gerrit-Owner: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: York Yang
york.yang@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 30 Jan 2019 07:43:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment