HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41286 )
Change subject: mb/mainboard/google/deltaur: Remove direct 'include <soc/gpio.h>' ......................................................................
mb/mainboard/google/deltaur: Remove direct 'include <soc/gpio.h>'
Don't directly include <soc/gpio.h>. All code using GPIO features should always and only include <gpio.h>, which should indirectly include the SoC-specific <soc/gpio.h>.
Change-Id: I186b287ab48002d73823128ad7bf74c1409cef37 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/google/deltaur/bootblock.c M src/mainboard/google/deltaur/chromeos.c M src/mainboard/google/deltaur/mainboard.c M src/mainboard/google/deltaur/variants/baseboard/gpio.c 4 files changed, 3 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/41286/1
diff --git a/src/mainboard/google/deltaur/bootblock.c b/src/mainboard/google/deltaur/bootblock.c index 5e5c462..fd45a78 100644 --- a/src/mainboard/google/deltaur/bootblock.c +++ b/src/mainboard/google/deltaur/bootblock.c @@ -6,7 +6,7 @@ #include <baseboard/variants.h> #include <bootblock_common.h> #include <ec/google/wilco/bootblock.h> -#include <soc/gpio.h> +#include <gpio.h> #include <variant/gpio.h>
static void early_config_gpio(void) diff --git a/src/mainboard/google/deltaur/chromeos.c b/src/mainboard/google/deltaur/chromeos.c index 89a48ce..0e96797 100644 --- a/src/mainboard/google/deltaur/chromeos.c +++ b/src/mainboard/google/deltaur/chromeos.c @@ -8,7 +8,6 @@ #include <baseboard/gpio.h> #include <boot/coreboot_tables.h> #include <gpio.h> -#include <soc/gpio.h> #include <variant/gpio.h> #include <vendorcode/google/chromeos/chromeos.h> #include <security/tpm/tss.h> diff --git a/src/mainboard/google/deltaur/mainboard.c b/src/mainboard/google/deltaur/mainboard.c index 6dd018e..0b4cdd5 100644 --- a/src/mainboard/google/deltaur/mainboard.c +++ b/src/mainboard/google/deltaur/mainboard.c @@ -6,7 +6,7 @@ #include <acpi/acpi.h> #include <baseboard/variants.h> #include <device/device.h> -#include <soc/gpio.h> +#include <gpio.h> #include <vendorcode/google/chromeos/chromeos.h> #include <variant/gpio.h>
diff --git a/src/mainboard/google/deltaur/variants/baseboard/gpio.c b/src/mainboard/google/deltaur/variants/baseboard/gpio.c index aabfdc12..139c511 100644 --- a/src/mainboard/google/deltaur/variants/baseboard/gpio.c +++ b/src/mainboard/google/deltaur/variants/baseboard/gpio.c @@ -6,7 +6,7 @@ #include <acpi/acpi.h> #include <baseboard/variants.h> #include <baseboard/gpio.h> -#include <soc/gpio.h> +#include <gpio.h> #include <variant/gpio.h>
static const struct pad_config gpio_table[] = {
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/41286 )
Change subject: mb/mainboard/google/deltaur: Remove direct 'include <soc/gpio.h>' ......................................................................
Abandoned
see #41324