Change in coreboot[master]: [NOTFORMERGE] soc/amd/picasso: test case for mpinit-problem on mandolin

[Felix Held (Code Review)]

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56355 )

Change subject: [NOTFORMERGE] soc/amd/picasso: test case for mpinit-problem on mandolin
......................................................................

[NOTFORMERGE] soc/amd/picasso: test case for mpinit-problem on mandolin

When printing a lot of stuff from the CPU init on BSP and all APs to the
serial console, the BSP will end up loading and running SeaBIOS before
the mpinit is done and before post_mp_init gets called which results in
SeaBIOS getting stuck when it tries to run the VGA option rom. Tested
this on mandolin, but this will likely be a problem on all Picasso and
Cezanne boards.

When removing the unconditional mca_print_error() call added in this
test case, the added debug print will show up on the console. When the
unconditional mca_print_error call is in there, the debug print in
post_mp_init won't show up on the serial console and the last message on
the serial console is: Running option rom at c000:0003

BUG=b:193809448

Change-Id: I48a3d820fcf9c26649e2385ea0caaef7d23ca572
Signed-off-by: Felix Held 
---
M src/soc/amd/common/block/cpu/mca/mca_common.c
M src/soc/amd/picasso/cpu.c
2 files changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/56355/1

diff --git a/src/soc/amd/common/block/cpu/mca/mca_common.c b/src/soc/amd/common/block/cpu/mca/mca_common.c
index b357691..cdad945 100644
--- a/src/soc/amd/common/block/cpu/mca/mca_common.c
+++ b/src/soc/amd/common/block/cpu/mca/mca_common.c
@@ -18,6 +18,7 @@
    	return;

for (unsigned int i = 0 ; i < num_banks ; i++) {
+		mca_print_error(i);
    	if (!mca_is_valid_bank(i))
    		continue;

diff --git a/src/soc/amd/picasso/cpu.c b/src/soc/amd/picasso/cpu.c
index b04d004..fee502e 100644
--- a/src/soc/amd/picasso/cpu.c
+++ b/src/soc/amd/picasso/cpu.c
@@ -40,6 +40,7 @@

static void post_mp_init(void)
 {
+	printk(BIOS_INFO, "post mp init smi enable\n\n\n");
    global_smi_enable();
    apm_control(APM_CNT_SMMINFO);
 }