Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41731 )
Change subject: docker/coreboot-jenkins-node: Add meson and ninja ......................................................................
docker/coreboot-jenkins-node: Add meson and ninja
Our jenkins instance is also used for flashrom, which can be built with meson, a mode that we want to be able to test, so add that.
ninja can be used as a backend to both meson and cmake (which coreboot will use to build cmocka for its unit tests) and may provide some additional coverage. Plus it's tiny but fast.
Change-Id: If454164852303144eaa72c4071c03ee89e863318 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M util/docker/coreboot-jenkins-node/Dockerfile 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/41731/1
diff --git a/util/docker/coreboot-jenkins-node/Dockerfile b/util/docker/coreboot-jenkins-node/Dockerfile index 73f7f18..554ebd2 100644 --- a/util/docker/coreboot-jenkins-node/Dockerfile +++ b/util/docker/coreboot-jenkins-node/Dockerfile @@ -19,6 +19,7 @@
RUN apt-get -y update && \ apt-get -y install \ + meson ninja-build \ lua5.3 liblua5.3-dev default-jre-headless openssh-server && \ apt-get clean
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41731 )
Change subject: docker/coreboot-jenkins-node: Add meson and ninja ......................................................................
Patch Set 1: Code-Review+1
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41731 )
Change subject: docker/coreboot-jenkins-node: Add meson and ninja ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41731 )
Change subject: docker/coreboot-jenkins-node: Add meson and ninja ......................................................................
Patch Set 1: Code-Review+1
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41731 )
Change subject: docker/coreboot-jenkins-node: Add meson and ninja ......................................................................
docker/coreboot-jenkins-node: Add meson and ninja
Our jenkins instance is also used for flashrom, which can be built with meson, a mode that we want to be able to test, so add that.
ninja can be used as a backend to both meson and cmake (which coreboot will use to build cmocka for its unit tests) and may provide some additional coverage. Plus it's tiny but fast.
Change-Id: If454164852303144eaa72c4071c03ee89e863318 Signed-off-by: Patrick Georgi pgeorgi@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/41731 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net --- M util/docker/coreboot-jenkins-node/Dockerfile 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
diff --git a/util/docker/coreboot-jenkins-node/Dockerfile b/util/docker/coreboot-jenkins-node/Dockerfile index 73f7f18..554ebd2 100644 --- a/util/docker/coreboot-jenkins-node/Dockerfile +++ b/util/docker/coreboot-jenkins-node/Dockerfile @@ -19,6 +19,7 @@
RUN apt-get -y update && \ apt-get -y install \ + meson ninja-build \ lua5.3 liblua5.3-dev default-jre-headless openssh-server && \ apt-get clean
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41731 )
Change subject: docker/coreboot-jenkins-node: Add meson and ninja ......................................................................
Patch Set 2:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/4274 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4273 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4272 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/4271
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Angel Pons (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)