Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37426 )
Change subject: soc/intel/tigerlake: Update Kconfig
......................................................................
Patch Set 11:
(5 comments)
https://review.coreboot.org/c/coreboot/+/37426/11//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/37426/11//COMMIT_MSG@11
PS11, Line 11: UART
This is not updated.
https://review.coreboot.org/c/coreboot/+/37426/11//COMMIT_MSG@11
PS11, Line 11: I2C
This is not updated.
https://review.coreboot.org/c/coreboot/+/37426/11//COMMIT_MSG@13
PS11, Line 13: PCH baseclock
Reference?
https://review.coreboot.org/c/coreboot/+/37426/9/src/soc/intel/tigerlake/Kco...
File src/soc/intel/tigerlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/37426/9/src/soc/intel/tigerlake/Kco...
PS9, Line 102: if SOC_INTEL_TIGERLAKE
Use default for Tigerlake which does not require condition.
I think its easier to read
https://review.coreboot.org/c/coreboot/+/37426/9/src/soc/intel/tigerlake/Kco...
PS9, Line 149: if SOC_INTEL_TIGERLAKE
Use default for Tigerlake which does not require condition.
FWIW, I think it is easier to read if SOC_INTEL_TIGERLAKE is still in there. It makes it clear what the value is for TGL v/s JSL.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37426
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I04020d55f1063d521b15f8d0dabbd6f1dabf577c
Gerrit-Change-Number: 37426
Gerrit-PatchSet: 11
Gerrit-Owner: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Venkata Krishna Nimmagadda
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Ravishankar Sarawadi
ravishankar.sarawadi@intel.corp-partner.google.com
Gerrit-Comment-Date: Sun, 22 Dec 2019 16:29:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-MessageType: comment