Attention is currently required from: Felix Held, Martin L Roth, Varshit Pandya.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82262?usp=email )
Change subject: vc/amd/opensil: introduce common mpio/chip.h header file
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/amd/onyx_poc/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/82262/comment/b822b8bc_895e4a15 :
PS1, Line 58: vendorcode/amd/opensil/mpio
Instead of just dropping it directly into the opensil directory, can we put it in amd/opensil/chips/mpio or something like that? amd/opensil/mpio just seems a bit odd to me.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82262?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iead97d1727569ec0d23a2b9c4fd96daff4bebcf6
Gerrit-Change-Number: 82262
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-CC: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 08 May 2024 20:43:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment