Change in ...coreboot[master]: soc/intel/braswell/include/soc/pci_devs.h: Add PUINIT_DEV
Frans Hendriks has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31711
Change subject: soc/intel/braswell/include/soc/pci_devs.h: Add PUINIT_DEV ......................................................................
soc/intel/braswell/include/soc/pci_devs.h: Add PUINIT_DEV
Intel Braswell P-UNIT is missing in pci_devs.h Add PUNIT device, function and device ID
BUG=N/A TEST=Facebook FBG-1701 booting Embedded Linux
Change-Id: I80c87c8964b3ba830571e0c03c424b67729a0c1a Signed-off-by: Frans Hendriks fhendriks@eltan.com --- M src/soc/intel/braswell/include/soc/pci_devs.h 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/31711/1
diff --git a/src/soc/intel/braswell/include/soc/pci_devs.h b/src/soc/intel/braswell/include/soc/pci_devs.h index c26eefb..8b06aff 100644 --- a/src/soc/intel/braswell/include/soc/pci_devs.h +++ b/src/soc/intel/braswell/include/soc/pci_devs.h @@ -3,6 +3,7 @@ * * Copyright (C) 2013 Google Inc. * Copyright (C) 2015 Intel Corp. + * Copyright (C) 2019 Eltan B.V. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -29,6 +30,11 @@ #define GFX_FUNC 0 # define GFX_DEVID 0x22b1
+/* P-Unit DPTF */ +#define PUNIT_DEV 0xB +#define PUNIT_FUNC 0 +#define PUNIT_DEVID 0x22DC + /* MMC Port */ #define MMC_DEV 0x10 #define MMC_FUNC 0
Hello Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31711
to look at the new patch set (#2).
Change subject: soc/intel/braswell/include/soc/pci_devs.h: Add PUNIT_DEV ......................................................................
soc/intel/braswell/include/soc/pci_devs.h: Add PUNIT_DEV
Intel Braswell P-UNIT is missing in pci_devs.h Add PUNIT device, function and device ID
BUG=N/A TEST=Facebook FBG-1701 booting Embedded Linux
Change-Id: I80c87c8964b3ba830571e0c03c424b67729a0c1a Signed-off-by: Frans Hendriks fhendriks@eltan.com --- M src/soc/intel/braswell/include/soc/pci_devs.h 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/31711/2
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31711 )
Change subject: soc/intel/braswell/include/soc/pci_devs.h: Add PUNIT_DEV ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31711 )
Change subject: soc/intel/braswell/include/soc/pci_devs.h: Add PUNIT_DEV ......................................................................
soc/intel/braswell/include/soc/pci_devs.h: Add PUNIT_DEV
Intel Braswell P-UNIT is missing in pci_devs.h Add PUNIT device, function and device ID
BUG=N/A TEST=Facebook FBG-1701 booting Embedded Linux
Change-Id: I80c87c8964b3ba830571e0c03c424b67729a0c1a Signed-off-by: Frans Hendriks fhendriks@eltan.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/31711 Reviewed-by: Michał Żygowski michal.zygowski@3mdeb.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/braswell/include/soc/pci_devs.h 1 file changed, 6 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Michał Żygowski: Looks good to me, approved
diff --git a/src/soc/intel/braswell/include/soc/pci_devs.h b/src/soc/intel/braswell/include/soc/pci_devs.h index c26eefb..8b06aff 100644 --- a/src/soc/intel/braswell/include/soc/pci_devs.h +++ b/src/soc/intel/braswell/include/soc/pci_devs.h @@ -3,6 +3,7 @@ * * Copyright (C) 2013 Google Inc. * Copyright (C) 2015 Intel Corp. + * Copyright (C) 2019 Eltan B.V. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -29,6 +30,11 @@ #define GFX_FUNC 0 # define GFX_DEVID 0x22b1
+/* P-Unit DPTF */ +#define PUNIT_DEV 0xB +#define PUNIT_FUNC 0 +#define PUNIT_DEVID 0x22DC + /* MMC Port */ #define MMC_DEV 0x10 #define MMC_FUNC 0
-
Frans Hendriks (Code Review) -
Michał Żygowski (Code Review)
-
Patrick Georgi (Code Review)