Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47186 )
Change subject: mb/purism/librem_mini: Increase TDP/PL2 setting ......................................................................
mb/purism/librem_mini: Increase TDP/PL2 setting
PL2 was set artificially low during development when the active cooling fan was not functional, and never corrected once the fan was fixed. Raise PL2 to a value which works with both Librem Mini variants.
Change-Id: Ie377392020f73359aed80ddae727adb6f8d06344 Signed-off-by: Matt DeVillier matt.devillier@puri.sm --- M src/mainboard/purism/librem_cnl/variants/librem_mini/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/47186/1
diff --git a/src/mainboard/purism/librem_cnl/variants/librem_mini/devicetree.cb b/src/mainboard/purism/librem_cnl/variants/librem_mini/devicetree.cb index 308fa69..9d2b34b 100644 --- a/src/mainboard/purism/librem_cnl/variants/librem_mini/devicetree.cb +++ b/src/mainboard/purism/librem_cnl/variants/librem_mini/devicetree.cb @@ -8,7 +8,7 @@ # Power limit register "power_limits_config" = "{ .tdp_pl1_override = 25, - .tdp_pl2_override = 28, + .tdp_pl2_override = 51, }"
# Enable Enhanced Intel SpeedStep
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47186 )
Change subject: mb/purism/librem_mini: Increase TDP/PL2 setting ......................................................................
Patch Set 1: Code-Review+2
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47186 )
Change subject: mb/purism/librem_mini: Increase TDP/PL2 setting ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47186/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47186/1//COMMIT_MSG@11 PS1, Line 11: which works with both Librem Mini variants well, when one of both support a higher value, why not use a overridetree?
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47186 )
Change subject: mb/purism/librem_mini: Increase TDP/PL2 setting ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47186/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47186/1//COMMIT_MSG@11 PS1, Line 11: which works with both Librem Mini variants
well, when one of both support a higher value, why not use a overridetree?
Both variants can use the same value. It's just that the fan on the WHL minis originally wasn't working with coreboot (was fixed with an EC FW update) and the PL2 value was lowered to avoid literal meltdown. Now that the fan is working, there's no reason to use the lower value anymore.
Since both devices use very similar boards (main difference is the SoC they come with), there's no need to use overridetrees at all. I've even seen WHL and CML chips which have the same CPUID.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47186 )
Change subject: mb/purism/librem_mini: Increase TDP/PL2 setting ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/47186/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47186/1//COMMIT_MSG@11 PS1, Line 11: which works with both Librem Mini variants
Both variants can use the same value. […]
ack
Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47186 )
Change subject: mb/purism/librem_mini: Increase TDP/PL2 setting ......................................................................
mb/purism/librem_mini: Increase TDP/PL2 setting
PL2 was set artificially low during development when the active cooling fan was not functional, and never corrected once the fan was fixed. Raise PL2 to a value which works with both Librem Mini variants.
Change-Id: Ie377392020f73359aed80ddae727adb6f8d06344 Signed-off-by: Matt DeVillier matt.devillier@puri.sm Reviewed-on: https://review.coreboot.org/c/coreboot/+/47186 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Michael Niewöhner foss@mniewoehner.de --- M src/mainboard/purism/librem_cnl/variants/librem_mini/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Michael Niewöhner: Looks good to me, approved
diff --git a/src/mainboard/purism/librem_cnl/variants/librem_mini/devicetree.cb b/src/mainboard/purism/librem_cnl/variants/librem_mini/devicetree.cb index 308fa69..9d2b34b 100644 --- a/src/mainboard/purism/librem_cnl/variants/librem_mini/devicetree.cb +++ b/src/mainboard/purism/librem_cnl/variants/librem_mini/devicetree.cb @@ -8,7 +8,7 @@ # Power limit register "power_limits_config" = "{ .tdp_pl1_override = 25, - .tdp_pl2_override = 28, + .tdp_pl2_override = 51, }"
# Enable Enhanced Intel SpeedStep
-
Angel Pons (Code Review) -
Matt DeVillier (Code Review)
-
Michael Niewöhner (Code Review)