Change in coreboot[master]: mb/google/hatch: Add 16G 3200 generic SPD file

List overview All Threads
Download

newer

older

Change in coreboot[master]: arm64:...

Change in coreboot[master]:...

Shelley Chen (Code Review)

28 Aug 2019 28 Aug '19

10:30 p.m.

Shelley Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35138 )

Change subject: mb/google/hatch: Add 16G 3200 generic SPD file ......................................................................

mb/google/hatch: Add 16G 3200 generic SPD file

BUG=b:139792883 BRANCH=None TEST=None

Change-Id: I22974b015a40fb7ae592e182cf5da83a8252c031 Signed-off-by: Shelley Chen shchen@google.com --- A src/mainboard/google/hatch/spd/16G_3200.spd.hex 1 file changed, 32 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/35138/1

diff --git a/src/mainboard/google/hatch/spd/16G_3200.spd.hex b/src/mainboard/google/hatch/spd/16G_3200.spd.hex new file mode 100644 index 0000000..09e1206 --- /dev/null +++ b/src/mainboard/google/hatch/spd/16G_3200.spd.hex @@ -0,0 +1,32 @@ +23 11 0C 03 46 29 00 08 00 60 00 03 02 03 00 00 +00 00 05 0D F8 FF 2B 00 6E 6E 6E 11 00 6E F0 0A +20 08 00 05 00 F0 2B 34 28 00 78 00 14 3C 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 16 36 0B 35 +16 36 0B 35 00 00 16 36 0B 35 16 36 0B 35 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 9C B5 00 00 00 00 E7 00 40 36 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00

Attachments:

attachment.htm (text/html — 5.2 KB)

Show replies by date

Tim Wawrzynczak (Code Review)

28 Aug 28 Aug

11:20 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35138 )

Change subject: mb/google/hatch: Add 16G 3200 generic SPD file ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/35138 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I22974b015a40fb7ae592e182cf5da83a8252c031 Gerrit-Change-Number: 35138 Gerrit-PatchSet: 1 Gerrit-Owner: Shelley Chen shchen@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 28 Aug 2019 21:20:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

11:21 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35138 )

Change subject: mb/google/hatch: Add 16G 3200 generic SPD file ......................................................................

Patch Set 1:

I take it no one is using this yet?

-- To view, visit https://review.coreboot.org/c/coreboot/+/35138 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I22974b015a40fb7ae592e182cf5da83a8252c031 Gerrit-Change-Number: 35138 Gerrit-PatchSet: 1 Gerrit-Owner: Shelley Chen shchen@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 28 Aug 2019 21:21:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Paul Fagerburg (Code Review)

29 Aug 29 Aug

12:27 a.m.

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35138 )

Change subject: mb/google/hatch: Add 16G 3200 generic SPD file ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/35138 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I22974b015a40fb7ae592e182cf5da83a8252c031 Gerrit-Change-Number: 35138 Gerrit-PatchSet: 1 Gerrit-Owner: Shelley Chen shchen@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 28 Aug 2019 22:27:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Shelley Chen (Code Review)

12:42 a.m.

Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35138 )

Change subject: mb/google/hatch: Add 16G 3200 generic SPD file ......................................................................

Patch Set 1:

...

Patch Set 1:

I take it no one is using this yet?

Not yet. To go into one of the upcoming variants :).

-- To view, visit https://review.coreboot.org/c/coreboot/+/35138 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I22974b015a40fb7ae592e182cf5da83a8252c031 Gerrit-Change-Number: 35138 Gerrit-PatchSet: 1 Gerrit-Owner: Shelley Chen shchen@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 28 Aug 2019 22:42:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

1:35 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35138 )

Change subject: mb/google/hatch: Add 16G 3200 generic SPD file ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35138/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/35138/1//COMMIT_MSG@7 PS1, Line 7: generic I am guessing this was already cleaned up to remove any part specific information like you did for previous SPDs.

-- To view, visit https://review.coreboot.org/c/coreboot/+/35138 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I22974b015a40fb7ae592e182cf5da83a8252c031 Gerrit-Change-Number: 35138 Gerrit-PatchSet: 1 Gerrit-Owner: Shelley Chen shchen@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 28 Aug 2019 23:35:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Paul Fagerburg (Code Review)

2:12 a.m.

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35138 )

Change subject: mb/google/hatch: Add 16G 3200 generic SPD file ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35138/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/35138/1//COMMIT_MSG@7 PS1, Line 7: generic

...

I am guessing this was already cleaned up to remove any part specific information like you did for p […]

As part of my review, I verified that it didn't the mfg p/n and other strings.

-- To view, visit https://review.coreboot.org/c/coreboot/+/35138 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I22974b015a40fb7ae592e182cf5da83a8252c031 Gerrit-Change-Number: 35138 Gerrit-PatchSet: 1 Gerrit-Owner: Shelley Chen shchen@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 29 Aug 2019 00:12:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

2:21 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35138 )

Change subject: mb/google/hatch: Add 16G 3200 generic SPD file ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35138/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/35138/1//COMMIT_MSG@7 PS1, Line 7: generic

...

As part of my review, I verified that it didn't the mfg p/n and other strings.

Thanks Paul!

-- To view, visit https://review.coreboot.org/c/coreboot/+/35138 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I22974b015a40fb7ae592e182cf5da83a8252c031 Gerrit-Change-Number: 35138 Gerrit-PatchSet: 1 Gerrit-Owner: Shelley Chen shchen@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 29 Aug 2019 00:21:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Fagerburg pfagerburg@chromium.org Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Shelley Chen (Code Review)

6:05 a.m.

Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35138 )

Change subject: mb/google/hatch: Add 16G 3200 generic SPD file ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35138/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/35138/1//COMMIT_MSG@7 PS1, Line 7: generic

...

Thanks Paul!

Yes, as Paul mentioned, all part numbers and manufacturer's ids have been zeroed out.

-- To view, visit https://review.coreboot.org/c/coreboot/+/35138 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I22974b015a40fb7ae592e182cf5da83a8252c031 Gerrit-Change-Number: 35138 Gerrit-PatchSet: 1 Gerrit-Owner: Shelley Chen shchen@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 29 Aug 2019 04:05:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Fagerburg pfagerburg@chromium.org Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Patrick Georgi (Code Review)

30 Aug 30 Aug

12:37 p.m.

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/35138 )

Change subject: mb/google/hatch: Add 16G 3200 generic SPD file ......................................................................

mb/google/hatch: Add 16G 3200 generic SPD file

BUG=b:139792883 BRANCH=None TEST=None

Change-Id: I22974b015a40fb7ae592e182cf5da83a8252c031 Signed-off-by: Shelley Chen shchen@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35138 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Paul Fagerburg pfagerburg@chromium.org --- A src/mainboard/google/hatch/spd/16G_3200.spd.hex 1 file changed, 32 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, but someone else must approve Paul Fagerburg: Looks good to me, approved

-- To view, visit https://review.coreboot.org/c/coreboot/+/35138 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I22974b015a40fb7ae592e182cf5da83a8252c031 Gerrit-Change-Number: 35138 Gerrit-PatchSet: 2 Gerrit-Owner: Shelley Chen shchen@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

2071

days inactive

2073

days old

coreboot-gerrit@coreboot.org

9 comments

5 participants

tags (0)

participants (5)

Furquan Shaikh (Code Review)
Patrick Georgi (Code Review)
Paul Fagerburg (Code Review)
Shelley Chen (Code Review)
Tim Wawrzynczak (Code Review)