Attention is currently required from: Paul Menzel, Yidi Lin, cong yang.
Ruihai Zhou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74051 )
Change subject: mb/google/corsola: Add support for mipi panel
......................................................................
Patch Set 17:
(3 comments)
This change is ready for review.
File src/mainboard/google/corsola/display.c:
https://review.coreboot.org/c/coreboot/+/74051/comment/82ef13ec_269445c1
PS11, Line 127: printk(BIOS_ERR, "Failed to read i2c: addr(%u)\n", addr);
add the function name and bus, do you think this is okay?
Done
File src/mainboard/google/corsola/display.c:
https://review.coreboot.org/c/coreboot/+/74051/comment/be57fc6d_cd83d80d
PS15, Line 138: /* Initialize I2C3 for PMIC TPS65132 */
I2C6
Done
File src/mainboard/google/corsola/panel_starmie.c:
https://review.coreboot.org/c/coreboot/+/74051/comment/d0e72ec6_541c3dee
PS15, Line 13: mainboard_set_regulator_voltage(MTK_
You also need to enable the regulator.
Done on CB:74341
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74051
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6f079e54f0317ff2f685f0e3834ebd1ceb8e9fcb
Gerrit-Change-Number: 74051
Gerrit-PatchSet: 17
Gerrit-Owner: Ruihai Zhou
zhouruihai@huaqin.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: cong yang
yangcong5@huaqin.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Yidi Lin
yidilin@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: cong yang
yangcong5@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Sat, 29 Apr 2023 06:14:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Ruihai Zhou
zhouruihai@huaqin.corp-partner.google.com
Comment-In-Reply-To: cong yang
yangcong5@huaqin.corp-partner.google.com
Comment-In-Reply-To: Yidi Lin
yidilin@google.com
Gerrit-MessageType: comment