Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29897 )
Change subject: util/inteltool: Add Apollo Lake GPIO groups and names ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/#/c/29897/2/util/inteltool/gpio_groups.c File util/inteltool/gpio_groups.c:
https://review.coreboot.org/#/c/29897/2/util/inteltool/gpio_groups.c@141 PS2, Line 141: .pcr_port_id = 0xc5, Where can I find this id? I couldn't find it in the datasheets.
https://review.coreboot.org/#/c/29897/2/util/inteltool/gpio_groups.c@239 PS2, Line 239: .pcr_port_id = 0xc4, Same here.
https://review.coreboot.org/#/c/29897/2/util/inteltool/gpio_groups.c@303 PS2, Line 303: .pcr_port_id = 0xc0, Same here.
https://review.coreboot.org/#/c/29897/2/util/inteltool/gpio_groups.c@371 PS2, Line 371: .pcr_port_id = 0xc7, Same here.
-
Felix Singer (Code Review)