Idwer Vollering has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38227 )
Change subject: util/lint: use env to locate the bash binary ......................................................................
util/lint: use env to locate the bash binary
Otherwise there will, after make gitconfig, be (hidden) shell command failures: gmake: util/lint/check-style: Command not found gmake: *** [Makefile.inc:632: check-style] Error 127
Change-Id: I3891dee53702ee10e5e44dae408193e49d7a89f1 Signed-off-by: Idwer Vollering vidwer@gmail.com --- M util/lint/check-style 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/38227/1
diff --git a/util/lint/check-style b/util/lint/check-style index f72d7b4..5d21b8b 100755 --- a/util/lint/check-style +++ b/util/lint/check-style @@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash # git pre-commit hook that runs an clang-format stylecheck. # Features: # - abort commit when commit does not comply with the style guidelines
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38227
to look at the new patch set (#2).
Change subject: util/lint: use env to locate the bash binary ......................................................................
util/lint: use env to locate the bash binary
Otherwise there will, after make gitconfig, be (hidden) shell command failures with 'git commit -s': gmake: util/lint/check-style: Command not found gmake: *** [Makefile.inc:632: check-style] Error 127
Change-Id: I3891dee53702ee10e5e44dae408193e49d7a89f1 Signed-off-by: Idwer Vollering vidwer@gmail.com --- M util/lint/check-style 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/38227/2
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38227 )
Change subject: util/lint: use env to locate the bash binary ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38227 )
Change subject: util/lint: use env to locate the bash binary ......................................................................
util/lint: use env to locate the bash binary
Otherwise there will, after make gitconfig, be (hidden) shell command failures with 'git commit -s': gmake: util/lint/check-style: Command not found gmake: *** [Makefile.inc:632: check-style] Error 127
Change-Id: I3891dee53702ee10e5e44dae408193e49d7a89f1 Signed-off-by: Idwer Vollering vidwer@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38227 Reviewed-by: Patrick Georgi pgeorgi@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M util/lint/check-style 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/util/lint/check-style b/util/lint/check-style index f72d7b4..5d21b8b 100755 --- a/util/lint/check-style +++ b/util/lint/check-style @@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash # git pre-commit hook that runs an clang-format stylecheck. # Features: # - abort commit when commit does not comply with the style guidelines
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38227 )
Change subject: util/lint: use env to locate the bash binary ......................................................................
Patch Set 3:
Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/1117 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1116 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1115
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Idwer Vollering (Code Review)
-
Patrick Georgi (Code Review)