Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69159?usp=email )
Change subject: security/tpm: make tis_probe() return tpm_family
......................................................................
Patch Set 27:
(1 comment)
Patchset:
PS27:
With this patch we get problems on timeless build with mainboard siemens/mc_ehl1. […]
I tried building the board with `BUILD_TIMELESS=1` set and it succeeded but of course you probably customize config. Also don't see timeless build affecting section sizes.
This patch doesn't add much code (some parameters and an error string), so you were probably running out of space there and many things could have caused the overlap (like toolchain changes) and it just happened to be this change. I don't really see what could be thrown away to reduce size (would returning a struct instead of using output parameter help?). I'd look into why timeless builds have tighter space requirements and whether that could be lifted.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69159?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5006e0cdfef76ff79ce9e1cf280fcd5515ae01b0
Gerrit-Change-Number: 69159
Gerrit-PatchSet: 27
Gerrit-Owner: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Uwe Poeche
uwe.poeche@siemens.com
Gerrit-Comment-Date: Wed, 03 Apr 2024 13:49:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Uwe Poeche
uwe.poeche@siemens.com
Gerrit-MessageType: comment