Attention is currently required from: Angel Pons, Arthur Heymans, David Hendricks, Felix Singer, Hung-Wei Chen, Jonathan Zhang, Lean Sheng Tan, Paul Menzel.
Annie Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75598?usp=email )
Change subject: mb/inventec: Add Intel SPR server board Inventec Transformers ......................................................................
Patch Set 10:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75598/comment/840f4757_7d513b57 : PS9, Line 23: The board boots to Linux 4.19.6 with all 192 cores available.
Pretty old version. ;-) […]
@Paul Menzel Here's the log for different dmesg level <3>usb usb1-port3: over-current condition <3>usb usb1-port5: over-current condition <3>usb usb1-port6: over-current condition <3>usb usb1-port7: over-current condition <3>usb usb1-port8: over-current condition <4>nvme nvme0: missing or invalid SUBNQN field. <4>pnp 00:01: disabling [io 0x0010-0x001f] because it overlaps 0000:00:18.0 BAR 4 [io 0x0000-0x001f]
File src/mainboard/inventec/transformers/Kconfig:
https://review.coreboot.org/c/coreboot/+/75598/comment/ea8fc787_8ccf930f : PS8, Line 24: string
@
@Felix Singer, mainboard_dir will bw used in our uboot and kernel, it's not useless define.
https://review.coreboot.org/c/coreboot/+/75598/comment/29061b4b_84182388 : PS8, Line 28: string
same here
Done
https://review.coreboot.org/c/coreboot/+/75598/comment/1d21a43b_19dab929 : PS8, Line 32: string
same
Done
https://review.coreboot.org/c/coreboot/+/75598/comment/a67fe00d_943859e1 : PS8, Line 36: int
same
Done
File src/mainboard/inventec/transformers/devicetree.cb:
PS8:
Please use tabs instead of spaces in lines 9-11 and 25-39. […]
Done
File src/mainboard/inventec/transformers/ramstage.c:
https://review.coreboot.org/c/coreboot/+/75598/comment/f0b6c1d2_4c3f88b7 : PS8, Line 10: #define SLOT_ID_LEN 2 : static char slot_id_str[SLOT_ID_LEN]; : extern uint32_t heci_fw_sts(void); : extern uint32_t heci_cse_normal(void); : extern uint32_t heci_cse_done(void); : : //extern void cse_init(uintptr_t tempbar); :
I just noticed these declarations. […]
Done